Skip to content

[FE] feat: kakao oauth 추가#521

Open
serin-B wants to merge 12 commits into
dev-frontfrom
front/test/serin/gg
Open

[FE] feat: kakao oauth 추가#521
serin-B wants to merge 12 commits into
dev-frontfrom
front/test/serin/gg

Conversation

@serin-B

@serin-B serin-B commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@serin-B serin-B requested a review from JinhuiKim December 8, 2022 09:24

@JinhuiKim JinhuiKim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내용 확인 부탁드립니다.

Comment thread front/src/index.js
</PersistGate>
</Provider>
</React.StrictMode>
// <React.StrictMode>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React.StrictMod 사용하면 안되는 이유가 있나요?

@serin-B serin-B Dec 8, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<React.StrictMode> 때문에 get 요청이 2번씩 가더라고요!!
(검색해보니까 프로젝트의 src/index.js에서 <React.StrictMode> 태그로 이 감싸져있으면 개발모드에서 (개발 단계시 오류를 잘 잡기위해) 두 번씩 렌더링된다고 합니다!)
구현 과정에서 get 요청이 두 번 가서 오류가 나는 것 같다고 말씀해주셔서, 주석처리하고 테스트 해보았고, 그 뒤로 잘 되어서 일단 주석처리 하였습니다!
실제 서비스 배포할때에도 영향이 있는지는 조금 더 테스트해봐야할 것 같습니다!!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

논의 결과 수정이 필요한 부분으로 보입니다.

Comment thread front/src/api/authApi.js Outdated
Comment thread front/src/store/modules/authSlice.js
Comment thread front/src/components/RoutesComponent.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants