fix(vscode-web): add open_in parameter#937
Merged
Merged
Conversation
Contributor
Author
|
@DevelopmentCats Please, can you review this? |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new open_in input to the registry/coder/modules/vscode-web Terraform module so consumers can choose whether the VS Code Web app opens in a normal browser tab or the existing slim-window mode, aligning with coder_app.open_in behavior and addressing issue #929.
Changes:
- Introduces
variable "open_in"with validation (tab|slim-window) and defaultslim-window. - Passes
open_inthrough toresource "coder_app" "vscode-web". - Adds Terraform tests to verify default/custom values and validation failures; updates README examples to reference module version
1.6.0.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| registry/coder/modules/vscode-web/main.tf | Adds open_in input + validation and wires it into the coder_app resource. |
| registry/coder/modules/vscode-web/vscode-web.tftest.hcl | Adds plan-time tests covering default/custom/invalid open_in values. |
| registry/coder/modules/vscode-web/README.md | Bumps referenced module version in examples to 1.6.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an
open_ininput to thevscode-webmodule and pass it through tocoder_app.vscode-web.The input accepts
taborslim-windowand defaults toslim-window, preserving the existing behavior while allowing users to open VS Code Web in a normal browser tab.Type of Change
Module Information
Path:
registry/coder/modules/vscode-webNew version:
v1.6.0Breaking change: [ ] Yes [x] No
Testing & Validation
terraform test -verbose: 3 passed, 0 failed)terraform validate).github/scripts/version-bump.sh --ci minor origin/mainRelated Issues
Fixes #929