🤖 refactor: encode chat layout lanes#3385
Open
ammar-agent wants to merge 1 commit into
Open
Conversation
Collaborator
Author
ammar-agent
force-pushed
the
refactor/chat-layout-lanes
branch
from
dfc80d6 to
93a26d5
Compare
Collaborator
Author
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Centralize transcript-tail and composer-decoration layout policy behind semantic lane wrappers. Require layout chrome entries to use lane-specific factories so future banners must explicitly choose whether they belong inside the transcript scrollport or in stable composer chrome. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$0.56`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=0.56 -->
ammar-agent
force-pushed
the
refactor/chat-layout-lanes
branch
from
93a26d5 to
62d4c2a
Compare
Collaborator
Author
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Encode chat layout ownership with semantic transcript-tail and composer-decoration lanes. The shared lane implementation now owns each lane's alignment, data-component, and scroll-anchoring policy, while callers create lane-specific items through typed factories.
Background
Follow-up to #3383. That fix moved the concurrent local-agent warning out of the transcript tail; this refactor makes the same mistake harder to repeat by removing low-level layout knobs from ChatPane call sites and requiring new layout chrome to explicitly choose a lane.
Implementation
Validation
bun test src/browser/components/ChatPane/LayoutStackLane.test.tsxmake typecheckgit diff --checkmake static-checkRisks
Low-to-medium. This is intended as a structural refactor with no user-visible layout movement beyond the preceding #3383 change, but it touches shared chat chrome rendering and hydration height reservation tests. Regression risk is concentrated in transcript tail barriers and composer-adjacent banners.
Pains
This PR was initially opened as a stacked branch while #3383 was still open, then rebased onto
mainafter #3383 merged to remove the temporary base-branch conflict.Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$0.56