chore: code cleanup#17
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors small pieces of plugin configuration parsing and input handling to reduce ad-hoc types and avoid unnecessary work, without changing the user-facing behavior of QuickMap’s trigger button handling.
Changes:
- Replaced
std::pairreturn fromReadButton()with a smallButtonDefstruct and returned map values directly. - Removed redundant deleted move operations from
InputHandlerand markedSetButtonasnoexcept. - Avoided computing “held duration” on button release when a long-press already triggered the map, and moved
_pressTime.reset()to after dispatch.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Plugin.cpp | Introduces ButtonDef for button config parsing and returns structured values directly. |
| src/InputHandler.h | Removes redundant move-deletes and updates SetButton signature to noexcept. |
| src/InputHandler.cpp | Updates SetButton definition and streamlines button-up handling to skip unused duration computation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code cleanup