Problems saving title_tag#1
Open
kennyadsl wants to merge 10 commits into
Open
Conversation
|
Had the same problem, thanks! |
it's much better to use a separate extension like: https://github.com/kennyadsl/spree-sitemap-generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
good work with this extension,
In this pull request there is a lot of things that you can avoid to merge but I think that the last commit (e67861a) is really important because now it's impossible to save title_tag fields on products and taxon:
title_tag don't have to be attr_accessor or it will impossible to save it.
Thank you