fix(config): surface codemieAssistants and codemieSkills through ConfigLoader#387
Open
8nevil8 wants to merge 3 commits into
Open
fix(config): surface codemieAssistants and codemieSkills through ConfigLoader#3878nevil8 wants to merge 3 commits into
8nevil8 wants to merge 3 commits into
Conversation
…ader.load() Also skip cost-enricher acceptance tests when local transcripts are absent.
… fix - Add comment explaining filterProjectFields excludes codemieAssistants/Skills - Strengthen test 3 with model assertion to confirm local overlay was applied - Add symmetric test for codemieSkills not being overwritten by local config
Generated with AI Co-Authored-By: codemie-ai <codemie.ai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigLoader.loadGlobalConfigProfile()andloadLocalConfigProfile()spread only per-profiledata when returning a resolved profile, silently dropping
codemieAssistantsandcodemieSkillswhich live at the
MultiProviderConfigroot (not inside any profile). This caused the RegisteredAssistants tab to always appear empty even after running
codemie setup briannaor similar.Changes
src/utils/config.ts: bothloadGlobalConfigProfileandloadLocalConfigProfilenowforward
rawConfig.codemieAssistantsandrawConfig.codemieSkillsfrom the root into thereturned profile object
src/env/types.ts: added missingcodemieSkills?: CodemieSkill[]toProviderProfileso the field is type-safe through the full
CodeMieConfigOptionschainsrc/utils/__tests__/config-project-override.test.ts: four new tests covering globalassistants/skills forwarding and the "local without field does not overwrite global" invariant
src/cli/commands/analytics/cost/__tests__/cost-enricher.test.ts: pre-existing acceptancetests that required local transcript files now skip gracefully when those files are absent
(replaced
itLocalwith a per-fileitSessionfactory usingexistsSync)Testing
codemie setup brianna→Registered Assistantstab now shows the assistantChecklist
npm run ci)main