Skip to content

Allow cleartext HTTP stream URLs for any domain #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacobsparts wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow cleartext HTTP stream URLs for any domain #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Open the app and tap the **Settings** button to configure:
| Setting | Default | Description |
| --- | --- | --- |
| Stream Name | `Live Stream` | Display name shown in the notification |
| Stream URL | radiojar default | Full HTTP(S) URL of the audio stream |
| Stream URL | radiojar default | Full HTTP(S) URL of the audio stream; HTTP cleartext is allowed for any domain |
| Auto-start on Boot | **Enabled** | Start the stream automatically after device reboot |
| Auto-relaunch if Stopped | **Enabled** | Watchdogs automatically restart the stream after a crash, network loss, or stop |
| Reconnect Delay | 5 s | Base delay before the first reconnect attempt |
Expand Down
1 change: 1 addition & 0 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
android:roundIcon="@mipmap/ic_launcher_round"
android:supportsRtl="true"
android:theme="@style/Theme.StreamPlayer"
android:usesCleartextTraffic="true"
android:networkSecurityConfig="@xml/network_security_config">

<!-- ═══════════════════════════════════════════
Expand Down
15 changes: 5 additions & 10 deletions app/src/main/res/xml/network_security_config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
Allow cleartext (plain HTTP) connections to radiojar.com and its subdomains.
Allow cleartext (plain HTTP) connections for user-configured stream URLs.

Radiojar's stream.radiojar.com returns an HTTP 302 redirect to a fresh tokenized
stream URL on n0X.radiojar.com over plain HTTP. Android 9+ blocks cleartext by
default, so we explicitly permit it for radiojar.com only.

All other traffic remains HTTPS-only.
This app is configured by the user to play arbitrary live-stream endpoints.
Android 9+ blocks cleartext by default, so cleartext traffic is explicitly
permitted here for any domain the user enters.
-->
<network-security-config>
<domain-config cleartextTrafficPermitted="true">
<domain includeSubdomains="true">radiojar.com</domain>
</domain-config>
<base-config cleartextTrafficPermitted="false" />
<base-config cleartextTrafficPermitted="true" />
</network-security-config>