Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,224 @@
section > .modalContent {
width: 384px;
height: 664px;
display: inline-flex;
padding: 0 16px 32px 16px;
flex-direction: column;
justify-content: center;
align-items: center;
gap: 10px;
border-radius: 24px;
background: var(--Background-Primary, #fff);
box-shadow: 4px 4px 10px 0 rgba(36, 36, 36, 0.25);
box-sizing: border-box;
}

section > .modalContentDateOpen {
height: 930px;
}

section > .modalContentTimeOpen {
height: 848px;
}

section > .modalContentWeekdayOpen {
height: 759px;
}
Comment on lines +1 to +26

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

CSS 선택자에서 section > 부분은 Modal 컴포넌트의 내부 구현(오버레이를 <section>으로 렌더링)에 의존하게 되어 유지보수성을 저해할 수 있습니다. 만약 Modal 컴포넌트가 <div>를 사용하도록 리팩토링되면 이 스타일이 적용되지 않을 수 있습니다. 클래스 이름만으로도 충분히 구체적이므로 태그 이름 선택자 section을 제거하여 컴포넌트 간의 결합도를 낮추는 것이 좋습니다. 이 변경은 215라인의 @media 쿼리 내 선택자에도 동일하게 적용되어야 합니다.

.modalContent {
  width: 384px;
  height: 664px;
  display: inline-flex;
  padding: 0 16px 32px 16px;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  gap: 10px;
  border-radius: 24px;
  background: var(--Background-Primary, #fff);
  box-shadow: 4px 4px 10px 0 rgba(36, 36, 36, 0.25);
  box-sizing: border-box;
}

.modalContentDateOpen {
  height: 930px;
}

.modalContentTimeOpen {
  height: 848px;
}

.modalContentWeekdayOpen {
  height: 759px;
}


.container {
width: 100%;
height: 100%;
margin-top: 24px;
display: flex;
flex-direction: column;
gap: 20px;
}

.header {
display: flex;
flex-direction: column;
align-items: center;
gap: 8px;
}

.title {
margin: 0;
color: var(--Text-Primary, #1e293b);
font-family: Pretendard, sans-serif;
font-size: 16px;
font-style: normal;
font-weight: 500;
line-height: 19px;
}

.description {
margin: 0;
color: var(--Text-Default, #64748b);
text-align: center;
font-family: Pretendard, sans-serif;
font-size: 14px;
font-style: normal;
font-weight: 500;
line-height: 17px;
word-break: keep-all;
}

.form {
flex: 1;
min-height: 0;
display: flex;
flex-direction: column;
gap: 16px;
}

.fieldGroup {
display: flex;
flex-direction: column;
gap: 8px;
}

.label {
margin: 0;
color: var(--Text-Primary, #1e293b);
font-family: Pretendard, sans-serif;
font-size: 16px;
font-style: normal;
font-weight: 500;
line-height: 19px;
}

.todoTitleInput {
display: flex;
width: 100%;
height: 48px;
padding: 16px;
align-items: center;
gap: 10px;
border-radius: 12px;
border: 1px solid var(--Border-Primary, #e2e8f0);
background: var(--Background-Primary, #fff);
color: var(--Text-Primary, #1e293b);
}

.todoTitleInput::placeholder {
color: var(--Text-Default, #64748b);
font-family: Pretendard, sans-serif;
font-size: 16px;
font-style: normal;
font-weight: 400;
line-height: 19px;
}

.dateTimeInputRow {
display: flex;
align-items: center;
gap: 8px;
}

.dateInput,
.timeInput {
display: flex;
height: 48px;
padding: 16px;
align-items: center;
gap: 10px;
border-radius: 12px;
border: 1px solid var(--Border-Primary, #e2e8f0);
background: var(--Background-Primary, #fff);
color: var(--Text-Primary, #1e293b);
cursor: pointer;
}

.dateInput {
width: 204px;
}

.timeInput {
width: 124px;
}

.dateInput::placeholder,
.timeInput::placeholder {
color: var(--Text-Default, #64748b);
font-family: Pretendard, sans-serif;
font-size: 16px;
font-style: normal;
font-weight: 400;
line-height: 19px;
}

.activePickerInput {
border-color: var(--Interaction-Hover, #416ec8);
}

.calendarPanel,
.timePickerPanel {
display: flex;
justify-content: center;
}

.repeatDropdownButton {
width: 120px;
height: 40px;
}

.repeatDropdownMenu {
z-index: 20;
}

.weekdayButtonGroup {
display: flex;
align-items: center;
justify-content: space-between;
gap: 4px;
}

.memoInput {
display: flex;
height: 75px;
padding: 12px 16px;
align-items: flex-start;
gap: 10px;
align-self: stretch;
border-radius: 12px;
border: 1px solid var(--Border-Primary, #e2e8f0);
background: var(--Background-Primary, #fff);
}

.memoInput::placeholder {
color: var(--Text-Default, #64748b);
}

.footer {
margin-top: auto;
}

.submitButton {
display: flex;
width: 100%;
height: 48px;
padding: 14px 0;
justify-content: center;
align-items: center;
gap: 10px;
border-radius: 12px;
background: var(--Color-Brand-Primary, #5189fa);
color: var(--Text-inverse, #fff);
text-align: center;
font-family: Pretendard, sans-serif;
font-size: 16px;
font-style: normal;
font-weight: 600;
line-height: 19px;
}

@media (max-width: 480px) {
section > .modalContent,
section > .modalContentDateOpen,
section > .modalContentTimeOpen,
section > .modalContentWeekdayOpen {
width: 100%;
max-width: 384px;
border-radius: 24px 24px 0 0;
}
}
Loading
Loading