캘린더 컴포넌트 제작#37
Conversation
Summary of ChangesHello @HWAN0218, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 날짜 및 시간 선택 기능을 제공하기 위한 캘린더 컴포넌트와 시간 선택 컴포넌트를 새롭게 추가합니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| /* 년/월 타이틀: 500 */ | ||
| :global(.react-calendar__navigation__label) { | ||
| font-weight: 500; | ||
| font-size: 14px; | ||
| } | ||
|
|
||
| /* 요일(일 월 화 수 목 금 토): 500 */ | ||
| :global(.react-calendar__month-view__weekdays) { | ||
| font-weight: 500; | ||
| font-size: 14px; | ||
| } | ||
|
|
||
| /* 날짜 숫자: 400 */ | ||
| :global(.react-calendar__tile) { | ||
| font-weight: 400; | ||
| font-size: 14px; | ||
| } |
There was a problem hiding this comment.
이 파일의 여러 선택자에 대한 스타일 규칙이 중복으로 정의되어 있습니다. 가독성과 유지보수성을 위해 각 선택자에 대한 스타일을 하나의 규칙으로 통합하는 것이 좋습니다.
:global(.react-calendar__navigation__label)(55행, 173행):global(.react-calendar__month-view__weekdays)(65행, 179행):global(.react-calendar__tile)(93행, 185행)
각각의 경우, 나중에 나오는 규칙의 font-weight와 font-size를 앞서 나오는 규칙에 병합하고 이 블록(172-188행)과 같은 중복된 규칙은 제거하는 것을 권장합니다.
| }: CalendarProps) { | ||
| const [internalValue, setInternalValue] = useState<Date>(() => { | ||
| const initial = parseInputDate(inputValue, inputYear); | ||
| return (value ?? initial ?? new Date()) as Date; |
There was a problem hiding this comment.
useState의 초기값으로 사용된 value ?? initial ?? new Date() 표현식은 항상 Date 객체를 반환합니다. 따라서 as Date 타입 단언은 불필요하며, 제거해도 타입 추론에 문제가 없습니다.
| return (value ?? initial ?? new Date()) as Date; | |
| return (value ?? initial ?? new Date()); |
2 participants
Summary
Issue
Scope
포함
특이사항