Skip to content

토스트 컴포넌트#17

Merged
Jieunsse merged 5 commits into
mainfrom
feature/toast
Feb 3, 2026
Merged

토스트 컴포넌트#17
Jieunsse merged 5 commits into
mainfrom
feature/toast

Conversation

@Jieunsse

@Jieunsse Jieunsse commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • 이 PR에서 변경한 내용 한 줄 요약

토스트 컴포넌트 아토믹하게 개발

Issue

Scope

  • 포함

    • 변경한 내용
  • 특이사항

@Jieunsse Jieunsse added this to the 컴포넌트 milestone Feb 2, 2026
@Jieunsse Jieunsse self-assigned this Feb 2, 2026
@Jieunsse Jieunsse added the 기능추가 기능개발 및 추가할 때 사용해주세요. label Feb 2, 2026
@Jieunsse Jieunsse added this to workers Feb 2, 2026
@github-project-automation github-project-automation Bot moved this to 개발 대기중 in workers Feb 2, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Jieunsse, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 새로운 UI 컴포넌트인 CheckBox와 Toast 알림을 도입합니다. CheckBox 컴포넌트는 다양한 크기와 접근성 기능을 유연하게 지원하도록 설계되었습니다. Toast 컴포넌트는 구성 가능한 자동 닫힘 및 애니메이션을 통해 일시적인 알림을 제공합니다. 두 컴포넌트 모두 더 나은 구성과 재사용성을 위해 아토믹 구조를 따릅니다.

Highlights

  • 새로운 CheckBox 컴포넌트 추가: 크기, 라벨, 접근성 옵션을 갖춘 재사용 가능한 CheckBox 컴포넌트가 추가되었습니다.
  • 새로운 Toast 컴포넌트 구현: 라이프사이클 관리, 자동 닫힘, 애니메이션 기능을 포함하는 Toast 알림 컴포넌트가 구현되었습니다.
  • 컴포넌트 구조화: 두 컴포넌트 모두 로직, 스타일, 타입을 분리하여 아토믹 디자인 접근 방식을 따릅니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

토스트 컴포넌트와 체크박스 컴포넌트를 추가하는 PR이네요. 전반적으로 코드가 잘 구조화되어 있고, 특히 복잡한 로직을 커스텀 훅으로 분리한 점이 좋습니다. 리뷰 중 체크박스 컴포넌트의 잘못된 속성 사용, 오타, 그리고 토스트 컴포넌트 라이프사이클 관리 훅의 비효율적인 로직 등 몇 가지 개선점을 발견했습니다. 자세한 내용은 아래 댓글을 참고해주세요.

Comment thread src/components/checkbox/CheckBox.tsx Outdated
Comment thread src/components/checkbox/constants/constants.ts Outdated
Comment thread src/components/toast/hooks/useToastLifecycle.ts Outdated
Jieunsse and others added 3 commits February 3, 2026 23:00
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Jieunsse Jieunsse merged commit 9ea4304 into main Feb 3, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from 개발 대기중 to 개발 완료 in workers Feb 3, 2026
@Jieunsse Jieunsse deleted the feature/toast branch February 20, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

기능추가 기능개발 및 추가할 때 사용해주세요.

Projects

Status: 개발 완료

Development

Successfully merging this pull request may close these issues.

1 participant