Skip to content

feat(gui): quick access settings #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codedealer merged 1 commit into from
Sep 17, 2025
Merged

feat(gui): quick access settings #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 68 additions & 1 deletion src/gui-frontend/src/components/ClipperHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,30 @@
Settings
</el-button>
</el-button-group>
<div class="quick-settings">
<el-tooltip placement="bottom" effect="dark" content="Constant Rate Factor (0-51). Lower = higher quality/larger size. Empty = auto.">
<el-input
v-model="crfInput"
placeholder="CRF"
size="small"
style="width:70px"
@change="onCrfChange"
@blur="onCrfBlur"
clearable
/>
</el-tooltip>
<el-tooltip placement="bottom" effect="dark" content="Target Frames Per Second (1-300). Empty = keep source.">
<el-input
v-model="targetFpsInput"
placeholder="FPS"
size="small"
style="width:70px"
@change="onTargetFpsChange"
@blur="onTargetFpsBlur"
clearable
/>
</el-tooltip>
</div>
</div>

<QuickDownload @video-selected="$emit('video-selected', $event)" />
Expand All @@ -26,12 +50,14 @@
</template>

<script setup lang="ts">
import { ElButtonGroup, ElButton, ElTag } from 'element-plus'
import { ElButtonGroup, ElButton, ElTag, ElInput, ElTooltip } from 'element-plus'
import { Coin, Setting } from '@element-plus/icons-vue'
import QuickDownload from './QuickDownload.vue'
import type { EngineStatus } from '@/types/api'
import type { CachedVideo } from '@/types/cache'
import { ENGINE_STATUS } from '@/constants'
import { useSettingsStore } from '@/stores/settings'
import { ref, watch } from 'vue'

interface Props {
engineStatus: EngineStatus | null
Expand All @@ -46,6 +72,41 @@ interface Emits {
const props = defineProps<Props>()
defineEmits<Emits>()

// Settings store for quick updates
const settingsStore = useSettingsStore()
const crfInput = ref<string>('')
const targetFpsInput = ref<string>('')

function syncFromStore() {
const gs = settingsStore.generalSettings
crfInput.value = gs?.crf !== undefined && gs.crf !== null ? String(gs.crf) : ''
targetFpsInput.value = gs?.target_fps !== undefined && gs.target_fps !== null ? String(gs.target_fps) : ''
}
watch(() => settingsStore.generalSettings, syncFromStore, { deep: true })
syncFromStore()

async function commitSetting(key: 'crf' | 'target_fps', raw: string) {
if (!settingsStore.generalSettings) return
const trimmed = raw.trim()
if (trimmed === '') {
await settingsStore.updateGeneralSettings({ [key]: null })
return
}
const num = Number(trimmed)
if (Number.isNaN(num)) return // ignore invalid
if (key === 'crf') {
if (num < 0 || num > 51) return
} else if (key === 'target_fps') {
if (num < 1 || num > 300) return
}
await settingsStore.updateGeneralSettings({ [key]: num })
}

function onCrfChange(val: string) { crfInput.value = val }
function onCrfBlur() { commitSetting('crf', crfInput.value) }
function onTargetFpsChange(val: string) { targetFpsInput.value = val }
function onTargetFpsBlur() { commitSetting('target_fps', targetFpsInput.value) }

// Status helpers
function getStatusType() {
if (!props.engineStatus) return 'info'
Expand Down Expand Up @@ -75,4 +136,10 @@ function getStatusMessage() {
display: flex;
align-items: center;
}
.quick-settings {
display: flex;
align-items: center;
gap: 6px;
margin-left: 12px;
}
</style>
Loading