fix(worker): Resolve N+1 query in ProcessFlakesTask#975
Draft
sentry[bot] wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue within the
app.tasks.flakes.ProcessFlakesTaskby refactoring the flake processing logic.Changes Made:
get_testruns_for_uploadsto fetch all relevantTestrunobjects for a batch of uploads in a single database query, replacing individual queries per upload.handle_passto collect expiredFlakeobjects into a list, deferring their updates to a singleFlake.objects.bulk_updatecall after processing all uploads.Testrun.objects.bulk_updatecalls from within the per-upload loop into a singlebulk_updateoperation at the end ofprocess_flakes_for_commit.These changes significantly reduce the number of database queries executed during flake processing, improving overall task efficiency and reducing database load.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YP4