Skip to content

fix(worker): N+1 query in test analytics flake processing#972

Draft
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/ta-flakes-n-plus-1-oSHr0A
Draft

fix(worker): N+1 query in test analytics flake processing#972
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/ta-flakes-n-plus-1-oSHr0A

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry Bot commented Jun 3, 2026

This PR addresses an N+1 query issue identified in the app.tasks.flakes.ProcessFlakesTask (WORKER-YP1), specifically within the services.test_analytics.ta_process_flakes module.

Problem:
Previously, process_flakes_for_commit would iterate over each upload and call process_single_upload, which in turn would execute get_testruns(upload). This resulted in a separate database query for testruns for each upload, leading to an N+1 query pattern. Additionally, handle_pass was performing individual flake.save() calls when a flake expired, causing further per-row database updates.

Solution:

  1. Batch-fetch Testruns: Introduced get_testruns_for_uploads to fetch all relevant testruns for all uploads in a single database query. The results are then grouped by upload_id in Python.
  2. Refactored process_single_upload: Modified process_single_upload to accept a list of pre-fetched testruns, eliminating its internal database query.
  3. Deferred Flake Expiry Updates: Instead of immediate flake.save() calls in handle_pass, expiring flakes are now collected into a list (expiring_flakes) and updated in a single Flake.objects.bulk_update call after all uploads have been processed.
  4. Materialized Uploads Queryset: The uploads queryset is now explicitly converted to a list to ensure it's evaluated once and consistently used.

These changes significantly reduce the number of database queries executed during flake processing, improving performance and reducing database load.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes WORKER-YP1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants