fix(worker): N+1 query in ProcessFlakesTask for testruns and expired flakes#967
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(worker): N+1 query in ProcessFlakesTask for testruns and expired flakes#967sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query issue in
app.tasks.flakes.ProcessFlakesTask(apps/worker/services/test_analytics/ta_process_flakes.py).Problem:
Previously, when processing flakes for a commit:
process_flakes_for_commitwould fetch all relevant uploads for a commit.process_single_uploadwould then execute a separate database query viaget_testruns(upload)to fetch its associated testruns, leading to an N+1 query pattern.handle_passwould callflake.save()individually when a flake reached 30 recent passes, potentially causing many singleUPDATEstatements.Solution:
get_testrunsfunction has been refactored intoget_testruns_for_uploadsto fetch all testruns for all uploads related to a commit in a single database query usingupload_id__in.upload_idin memory before being passed toprocess_single_upload.handle_passno longer callsflake.save()directly. Instead, expired flakes are collected into a list and a singleFlake.objects.bulk_updateis performed after all uploads have been processed.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YNX