fix(ta): batch testrun updates in ProcessFlakesTask#951
Draft
sentry[bot] wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue identified in
app.tasks.flakes.ProcessFlakesTask, specifically within theservices/test_analytics/ta_process_flakes.pymodule.Problem:
Previously, the
process_flakes_for_commitfunction iterated over each upload, callingprocess_single_uploadfor every item. Each call toprocess_single_uploadthen executed a separateSELECTquery viaget_testrunsand abulk_updateon theta_timeseries_testruntable. This resulted in an N+1 query pattern, where N is the number of uploads, leading to inefficient database operations.Solution:
To resolve this, the following changes were implemented:
get_testrunsfunction modified: It now accepts a list ofupload_idsand filtersTestrunobjects usingupload_id__in, allowing all relevant testruns to be fetched in a single database query.process_single_uploadreplaced byprocess_all_uploads: The logic for processing testruns (handling passes and failures) was consolidated into a new function,process_all_uploads. This function operates on all testruns fetched in bulk and performs a singleTestrun.objects.bulk_updateat the end.process_flakes_for_commitupdated: The loop iterating over individual uploads and callingprocess_single_uploadhas been removed. Instead,process_flakes_for_commitnow collects all upload IDs and passes them to the newprocess_all_uploadsfunction, effectively reducing N SELECTs + N UPDATEs to a single SELECT + a single UPDATE operation.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YNC