fix(worker): eliminate N+1 query in ProcessFlakesTask#950
Draft
sentry[bot] wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query issue identified in the
ProcessFlakesTask, specifically within theprocess_flakes_for_commitfunction inapps/worker/services/test_analytics/ta_process_flakes.py.Problem:
Previously, for each commit, the
process_flakes_for_commitfunction would iterate throughNuploads. For eachupload, it would callprocess_single_upload, which in turn would perform a separateSELECTquery viaget_testruns(upload)and a separateTestrun.objects.bulk_updateoperation. This resulted inNSELECTqueries andNUPDATEqueries on theta_timeseries_testruntable, leading to an N+1 performance bottleneck.Solution:
To resolve this, the following changes were implemented:
get_all_testruns: A new functionget_all_testruns(upload_ids)was added. This function now fetches all relevantTestrunobjects for all givenupload_idsin a single batchedSELECTquery, significantly reducing database round-trips.process_single_upload: The signature ofprocess_single_uploadwas updated to accept a pre-fetched list ofTestrunobjects directly, removing its internalget_testrunscall and thebulk_updateoperation.process_flakes_for_commit: This function now first collects allupload.ids. It then callsget_all_testrunsonce to retrieve all necessaryTestrunobjects. After processing theseTestrunobjects in memory viaprocess_single_upload, a singleTestrun.objects.bulk_updateis performed at the end of the loop for all modifiedTestruninstances.Impact:
This change reduces the database operations for fetching and updating
Testrunobjects fromO(N)(where N is the number of uploads) toO(1), drastically improving the performance and reducing the load on the database during flake processing.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YNB