Draft
Implement all improvements.md runtime/config refactors in packaged mod source#3
improvements.md runtime/config refactors in packaged mod source#3Conversation
Agent-Logs-Url: https://github.com/codebooo/UCH-Knockback-Mod/sessions/16466fab-2ecb-41db-ad43-02e725d43060 Co-authored-by: codebooo <109243702+codebooo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update improvements as stated in improvements.md
Implement all Apr 6, 2026
improvements.md runtime/config refactors in packaged mod source
codebooo
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies the full set of improvements documented in
improvements.mdto the mod implementation shipped inKnockback_Mod_v1.0.0.zip. The update focuses on safer config handling, lower per-activation overhead, cleaner physics timing, and clearer plugin metadata/runtime behavior.Config + metadata hardening
AcceptableValueRange<float>.PluginGuid,PluginName,PluginVersion) and updated version usage to1.0.1.DebugLoggingconfig to gate high-frequency per-target logs.Runtime performance refactor
FindObjectsOfType<GameObject>()scans with non-alloc physics overlap queries (Physics2D.OverlapCircleNonAlloc,Physics.OverlapSphereNonAlloc).ToLower) in favor ofIndexOf(..., StringComparison.OrdinalIgnoreCase).Physics correctness + safety
UpdatetoFixedUpdatethrough a pending-action queue.Harmony behavior cleanup
PatchAll()initialization because no explicit patch classes exist in the plugin source.Packaged docs/metadata alignment
README.mdto reflect new behavior/settings and version alignment.