Benr/external server#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the MCP server architecture to externalize server instances, moving server creation responsibility from the library to the consumer. Instead of internally creating McpServer instances, the library now accepts either a pre-created server or a factory function to create servers.
- Removes internal McpServer instantiation and moves server creation to consumer code
- Adds validation for server/factory configuration with appropriate error handling and warnings
- Updates examples and documentation to reflect the new API requirements
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/smoke-e2e/server-demo.ts | Updates demo to provide external McpServer factory |
| tests/smoke-e2e/client-demo.ts | Adds response validation checks to smoke tests |
| tests/mcpServerOptionsValidator.test.ts | New test file for server options validation logic |
| tests/createMcpServer.test.ts | Refactored tests to work with external server architecture |
| src/server/validateOptions.ts | New validation module for server configuration options |
| src/server/createMcpServer.ts | Core refactor removing internal server creation, adding external server support |
| package.json | Version bump and new dev scripts |
| README.md | Updated documentation reflecting new API requirements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.