Skip to content

Benr/external server#2

Merged
imbenrabi merged 5 commits into
mainfrom
benr/external-server
Aug 13, 2025
Merged

Benr/external server#2
imbenrabi merged 5 commits into
mainfrom
benr/external-server

Conversation

@imbenrabi

Copy link
Copy Markdown
Contributor

No description provided.

@imbenrabi
imbenrabi requested a review from Copilot August 13, 2025 09:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the MCP server architecture to externalize server instances, moving server creation responsibility from the library to the consumer. Instead of internally creating McpServer instances, the library now accepts either a pre-created server or a factory function to create servers.

  • Removes internal McpServer instantiation and moves server creation to consumer code
  • Adds validation for server/factory configuration with appropriate error handling and warnings
  • Updates examples and documentation to reflect the new API requirements

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/smoke-e2e/server-demo.ts Updates demo to provide external McpServer factory
tests/smoke-e2e/client-demo.ts Adds response validation checks to smoke tests
tests/mcpServerOptionsValidator.test.ts New test file for server options validation logic
tests/createMcpServer.test.ts Refactored tests to work with external server architecture
src/server/validateOptions.ts New validation module for server configuration options
src/server/createMcpServer.ts Core refactor removing internal server creation, adding external server support
package.json Version bump and new dev scripts
README.md Updated documentation reflecting new API requirements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/server/validateOptions.ts Outdated
@imbenrabi
imbenrabi merged commit 75285df into main Aug 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants