fix: give the test suite its own git identity for CI runners - #15
Merged
Conversation
The session tests seed throwaway repos with git commit, which fails on
machines with no git identity configured (GitHub runners, fresh
installs): the repo then has no commits, worktree creation has nothing
to branch from, and 13 session assertions fail. The suite now exports
GIT_AUTHOR/COMMITTER identity itself instead of depending on ambient
config.
Also tightens two assertions that false-passed on the runner by
matching leftover index rows ("active"/"merged" anywhere in the file);
they now match the specific branch row.
Reproduced the CI failure locally with GIT_CONFIG_GLOBAL=/dev/null and
verified 123/123 both with and without ambient git config.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Nx3U4ZrUAmCpsCeSxvzRWX
d6veteran
pushed a commit
that referenced
this pull request
Jul 27, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nx3U4ZrUAmCpsCeSxvzRWX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
tests (linux)CI failure from #14's runs (13 failed session assertions, example run).Root cause: the session tests seed throwaway repos with
git commit --allow-empty, which fails on machines with no git identity configured, exactly what GitHub runners are. The repo then has no commits,git worktree addhas nothing to branch from, and every session assertion downstream fails. It passed locally only because the dev machine happened to haveuser.name/user.emailset.Fix: the suite exports
GIT_AUTHOR_*/GIT_COMMITTER_*itself, so it is self-contained on any machine. Also tightens two assertions that false-passed on the runner by matching leftover index rows (active/mergedanywhere in the file); they now match the specificfeat/session-testrow, so this failure mode can't hide again.Verification
GIT_CONFIG_GLOBAL=/dev/null GIT_CONFIG_SYSTEM=/dev/null bash tests/run.sh(same 13 session failures).🤖 Generated with Claude Code
https://claude.ai/code/session_01Nx3U4ZrUAmCpsCeSxvzRWX
Generated by Claude Code