Skip to content

fix: harden CLI per code review; require Bash 4+ #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d6veteran merged 2 commits into from
Jul 27, 2026
Merged

fix: harden CLI per code review; require Bash 4+ #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecb6e8f
fix: harden CLI file handling per code review (atomic writes, literal…
claude Jul 27, 2026
58f79c1
feat: require Bash 4 or newer, drop the stock-macOS Bash 3.2 floor
claude Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: CI

on:
push:
branches: [main]
pull_request:

jobs:
lint:
name: shellcheck
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: shellcheck (uses repo .shellcheckrc)
run: shellcheck bin/claude-team bin/team-session-start install.sh scripts/generate-agents.sh tests/run.sh

test-linux:
name: tests (linux)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Run test suite
run: bash tests/run.sh

test-macos:
name: tests (macos)
runs-on: macos-latest
steps:
- uses: actions/checkout@v4
- name: Install current bash (macOS ships 3.2, below the Bash 4+ floor)
run: brew list bash >/dev/null 2>&1 || brew install bash
- name: Run test suite
run: |
bash --version | head -1
bash tests/run.sh
4 changes: 0 additions & 4 deletions .shellcheckrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# ShellCheck configuration for claude-team-cli
# https://www.shellcheck.net/wiki/

# Allow sourcing from paths determined at runtime
# (e.g., sourcing profile files from ~/.claude/team/)
disable=SC1090

# Allow expressions in single-quoted strings (used in sed patterns)
disable=SC2016

Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

> Your AI development team. Sixteen specialists, one CLI, zero meetings.

![License: MIT](https://img.shields.io/badge/license-MIT-blue) ![Bash 3.2+](https://img.shields.io/badge/bash-3.2%2B-green) ![Works with Claude Code](https://img.shields.io/badge/works%20with-Claude%20Code-8A2BE2)
![License: MIT](https://img.shields.io/badge/license-MIT-blue) ![Bash 4+](https://img.shields.io/badge/bash-4%2B-green) ![Works with Claude Code](https://img.shields.io/badge/works%20with-Claude%20Code-8A2BE2)

---

Expand Down Expand Up @@ -813,7 +813,7 @@ claude-team-cli/
## Requirements

- macOS or Linux
- Bash 3.2+
- Bash 4+ (macOS ships Bash 3.2 at `/bin/bash`; install a current Bash with `brew install bash`)
- [Claude Code](https://claude.ai/code)

---
Expand Down
Loading
Loading