Skip to content

Fix Airflow proxy 500 on JS assets containing '$'/'\' (Airflow 3.2.2) #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iliyan-velichkov merged 1 commit into from
Jun 12, 2026
Merged

Fix Airflow proxy 500 on JS assets containing '$'/'\' (Airflow 3.2.2) #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions application/src/main/java/com/codbex/phoebe/proxy/TextResponseBodyRewriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,9 @@ private String rewriteFullURLs(ServerRequest request, String body) {

String replacement = newAirflowUrl + (extraPath != null ? "/" + extraPath : "");

matcher.appendReplacement(result, replacement);
// quoteReplacement escapes any '$' or '\' in the matched path (common in minified JS bundles)
// so they are not interpreted as group references by appendReplacement
matcher.appendReplacement(result, Matcher.quoteReplacement(replacement));
}
matcher.appendTail(result);

Expand All @@ -131,7 +133,7 @@ private String rewriteEncodedQueryParams(String body) {
String updatedPath = "/services/airflow" + decodedPath;
String reEncodedPath = URLEncoder.encode(updatedPath, StandardCharsets.UTF_8);

matcher.appendReplacement(result, paramName + reEncodedPath);
matcher.appendReplacement(result, Matcher.quoteReplacement(paramName + reEncodedPath));
}
matcher.appendTail(result);

Expand Down
15 changes: 15 additions & 0 deletions application/src/test/java/com/codbex/phoebe/proxy/TextResponseBodyRewriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,21 @@ void rewriteBody_shouldReplaceAirflowUrl_whenHostHeaderIsPresent() {
assertEquals(expectedBody, result);
}

@Test
void rewriteBody_shouldNotFail_whenAirflowUrlIsFollowedByDollarOrBackslash() {
// minified JS bundles (e.g. Airflow's static assets) may contain '$' or '\' right after the
// Airflow URL; these are special chars for Matcher.appendReplacement and previously caused
// an IllegalArgumentException: Illegal group reference -> HTTP 500
byte[] body = "var a=\"http://localhost:8080/path/$1\\foo\";".getBytes(StandardCharsets.UTF_8);
String expectedBody = "var a=\"http://localhost:8080/services/airflow/path/$1\\foo\";";

when(request.uri()).thenReturn(URI.create("http://localhost:8080/services/airflow"));

String result = rewriter.rewriteBody(request, body);

assertEquals(expectedBody, result);
}

@Test
void rewriteBody_shouldNotReplaceAirflowUrl_whenHostHeaderIsMissing() {
byte[] body = "<html><body>http://old-airflow-url</body></html>".getBytes(StandardCharsets.UTF_8);
Expand Down
Loading