Prepare cx@26.5.1: changelog, version bump, DateTimePicker endless scrolling#1297
Merged
Conversation
Brings the DateTimePicker infinite-scroll improvement (PR #1280, merged to feat/master/litmus-ts) onto master so it ships in cx@26.5.1. The date and time wheels render the option list three times and recentre on the nearest copy, so wraps are seamless with no hard list edges. Only the cycling feature is ported: DateTimePicker.tsx is master plus #1280, and Wheel.tsx is master plus the `cycle` prop. master's existing wheel-width fix (Wheel.scss) is kept untouched — the litmus-ts branch predates it, so its Wheel.tsx/Wheel.scss were not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares the
cx@26.5.1release: bumps the version, adds the changelog entry, and brings theDateTimePickerinfinite-scroll work ontomaster.Changes
Port DateTimePicker endless wheel scrolling — the improvement from PR #1280 was merged to
feat/master/litmus-ts, notmaster. That branch has diverged heavily, so only the cycling feature is ported here:DateTimePicker.tsx—master+ PR DateTimePicker: Infinite scroll for faster date/time selection #1280.Wheel.tsx—master+ acycleprop. When set,WheelComponentrenders the option listWHEEL_BUFFER_COPIES(3) times and snaps to the nearest copy of the value, so wraps are seamless with no remount.master'sWheel.scss(the 26.3.9 wheel-width fix) is kept untouched —feat/master/litmus-tspredates it, so its olderwheelWidthapproach was deliberately not used.Changelog + version — adds the
cx@26.5.1entry and bumpspackages/cx/package.jsonto26.5.1. The entry covers everything new onmastersince26.4.4:daybeforeformatter (Add adaybeforeformatter (date minus one day) #1290),quarterformatter,hideClippedLabelsaxis option (Last label on time axes gets clipped at the chart edge #1291),DateTimePickerendless scrolling.onCreateFiltermay returnnull,ValidationGroupvisitedpropagation (Visited is not propagated from ValidationGroup to the TextField properly, when visited is initialised #1276),RangeMarkerSCSS inclusion.Verification
yarn check-typesandyarn buildboth pass.