Include RangeMarker styles in the chart CSS build#1296
Merged
Conversation
RangeMarker.scss was missed in the Sass @use migration: it still relied on the legacy global scope for `$cx-besm`, `cx-should-include` and `$cx-default-range-marker-color`, so it could not be @use'd and was left out of charts/index.scss. As a result its styles never reached the compiled CSS and RangeMarker rendered unstyled. - RangeMarker.scss: @use besm, include and variables, like the other charts/*.scss files. - charts/index.scss: @use "RangeMarker" alongside the other components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RangeMarker.scsswas missed in the Sass@usemigration. It still referenced$cx-besm,cx-should-include, and$cx-default-range-marker-colorfrom the legacy global scope, so it couldn't be@used — andcharts/index.scss(correctly, at the time) left it out.The result:
RangeMarker.scsswas an orphaned file. Itscx-rangemarkermixin was never invoked, so the.{e}rangemarker-pathstyles (stroke colour, width,fill: none) never reached the compiled CSS — the component rendered unstyled.Fix
RangeMarker.scss—@usebesm,include, andvariables, matching every othercharts/*.scssfile.charts/index.scss—@use "RangeMarker"alongside the other chart components.Verification
yarn buildsucceeds, and the rule now appears inpackages/cx/dist/charts.css: