go.mod: bump cockroachdb/errors to v1.13.0#6121
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
github.com/cockroachdb/errorsfromv1.11.3tov1.13.0so that downstream projects pairing pebble with a newergetsentry/sentry-gocompile cleanly.go mod tidypullssentry-gofromv0.27.0tov0.46.0as a transitive indirect update; no pebble source changes are needed.Why this matters
As reported in #6092, pebble pins
cockroachdb/errors v1.11.3, which transitively requiresgetsentry/sentry-go v0.27.0. Newersentry-goreleases removedEvent.Extra, so any downstream that combines pebble with a newersentry-gofails to compile:inside
errors@v1.11.3/report/report.go.cockroachdb/errors v1.13.0migratedEvent.ExtratoEvent.Contextsand moved itssentry-gorequirement tov0.46.0, resolving the break. Pebble uses only the stableerrors.*wrapping APIs and never importserrors/reportor touchessentry.Event, so the migration is internal to the errors package and requires no code changes here. This adoption follows CockroachDB's own upstream direction, since the errors team shipped v1.13.0 specifically for this sentry compatibility fix.Testing
go build ./...passes (the previously-failing report path now compiles againstsentry-go v0.46.0).go mod tidyproduces no further diff togo.modorgo.sum.go mod verifyreports all modules verified.go test ./...compiles and passes.Fixes #6092