fix: handle null token usage stats without crashing sessions - #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Some OpenAI-compatible providers return
nullforprompt_tokens,completion_tokens, andtotal_tokensin streaming usage chunks.Those values were copied directly into message statistics. Persisted sessions containing null token counts or speeds could then crash
AssistantMessagewhen formatting the values, leaving the whole session view blank.The non-streaming path already normalizes nullish usage values.
Testing
npm run check: passedcreateTestServer()setup, followed by cleanup errors for uninitialized server handles. One run also observed a timing-sensitive failure inask-user.test.ts, whereisRunningremainedtrueafter a 100 ms wait. This patch does not modify E2E infrastructure, server startup, or ask-user session state.AI Model
OpenAI GPT-5.6