RecoHGCal/TICL: coding-rules compliance #51346
Open
felicepantaleo wants to merge 1 commit into
Open
Conversation
…ysis) Findings from cmsCodeRulesChecker, clang-format, scram b code-checks and the LLVM static analyzer (scram b checker) on the package. Include guards (TCR-1): three headers shared the guard RecoHGCal_TICL_PatternRecognitionAlgoBase_H__ (PatternRecognitionAlgoBase.h, TICLInterpretationAlgoBase.h, TracksterLinkingAlgoBase.h) -- a real bug, since a translation unit including two of them silently dropped the second body. Other guards used reserved double-underscore forms (..._H__, leading __...), wrong package casing (RecoHGCAL_/RECOHGCAL_), or a foreign-package guard (TICLGraph.h used DataFormats_HGCalReco_TICLGraph_h). Normalised all 41 to the canonical RecoHGCal_TICL_<File>_h; guards are now unique and free of reserved __. Static analyzer: - TiclDebugger: make the static-local lookup table fully const (static const char* const particle_kind[]) -- threadsafety.StaticLocal. - TracksterLinksProducer::dumpTrackster: remove the dead store of e_over_h (computed but only read by a compiled-out LogDebug) by inlining the expression.
Contributor
|
cms-bot internal usage |
Contributor
Author
|
@cmsbuild please test |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51346/49980
|
Contributor
|
A new Pull Request was created by @felicepantaleo for master. It involves the following packages:
@Moanwar, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
Author
|
type bugfix |
Contributor
|
+1 Size: This PR adds an extra 52KB to repository Comparison SummarySummary:
|
Contributor
Author
|
type ngt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings from cmsCodeRulesChecker, clang-format, scram b code-checks and the LLVM static analyzer (scram b checker) on the package.
Include guards (TCR-1): three headers shared the guard RecoHGCal_TICL_PatternRecognitionAlgoBase_H__ (PatternRecognitionAlgoBase.h, TICLInterpretationAlgoBase.h, TracksterLinkingAlgoBase.h) -- a real bug, since a translation unit including two of them silently dropped the second body. Other guards used reserved double-underscore forms (...H_, leading ...), wrong package casing (RecoHGCAL/RECOHGCAL), or a foreign-package guard (TICLGraph.h used DataFormats_HGCalReco_TICLGraph_h). Normalised all 41 to the canonical RecoHGCal_TICL__h; guards are now unique and free of reserved __.