Skip to content

RecoHGCal/TICL: seeding, layer-tile and barrel config fixes#51344

Open
felicepantaleo wants to merge 1 commit into
cms-sw:masterfrom
felicepantaleo:ticl-fix-seeding-tile-config
Open

RecoHGCal/TICL: seeding, layer-tile and barrel config fixes#51344
felicepantaleo wants to merge 1 commit into
cms-sw:masterfrom
felicepantaleo:ticl-fix-seeding-tile-config

Conversation

@felicepantaleo

@felicepantaleo felicepantaleo commented Jun 28, 2026

Copy link
Copy Markdown
Contributor
  • SeedingRegionByHF: cut on Et = energy/cosh(eta) (minEt is a transverse-energy threshold).
  • TICLLayerTileProducer: LogDebug no longer dereferences a null tile in HFNose mode.
  • CLUE3DBarrel_cff: algo_verbosity 9999 -> 0 (leftover debug flood).

@felicepantaleo
RecoHGCal/TICL: seeding, layer-tile and barrel config fixes
24ccaa6 
- SeedingRegionByHF: cut on Et = energy/cosh(eta) (minEt is a transverse-energy threshold).
- TICLLayerTileProducer: LogDebug no longer dereferences a null tile in HFNose mode.
- CLUE3DBarrel_cff: algo_verbosity 9999 -> 0 (leftover debug flood).
@cmsbuild cmsbuild added this to the CMSSW_20_1_X milestone Jun 28, 2026
@cmsbuild

cmsbuild commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@felicepantaleo

felicepantaleo commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild please test

@cmsbuild

cmsbuild commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51344/49976

@cmsbuild

cmsbuild commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

  • RecoHGCal/TICL (reconstruction)

@Moanwar, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@apsallid, @denizsun, @hatakeyamak, @lecriste, @rovere, @salimcerci, @sameasy, @sobhatta this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@felicepantaleo

felicepantaleo commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

type bugfix

@cmsbuild

cmsbuild commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f7fdf/54335/summary.html
COMMIT: 24ccaa6
CMSSW: CMSSW_20_1_X_2026-06-28-0000/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51344/54335/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3414477
  • DQMHistoTests: Total failures: 68
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3414391
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@felicepantaleo

felicepantaleo commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

type ngt

@cmsbuild cmsbuild added the ngt label Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug-fix code-checks-approved ngt orp-pending pending-signatures reconstruction-pending tests-approved

Projects

None yet

Milestone

CMSSW_20_1_X

Development

Successfully merging this pull request may close these issues.

2 participants

@felicepantaleo @cmsbuild