Skip to content

RecoHGCal/TICL: TICLDumper fixes#51343

Open
felicepantaleo wants to merge 1 commit into
cms-sw:masterfrom
felicepantaleo:ticl-fix-dumper
Open

RecoHGCal/TICL: TICLDumper fixes#51343
felicepantaleo wants to merge 1 commit into
cms-sw:masterfrom
felicepantaleo:ticl-fix-dumper

Conversation

@felicepantaleo

Copy link
Copy Markdown
Contributor
  • saveTICLCandidate_ read the wrong parameter key (saveSimTICLCandidate).
  • candidate trackster index computed against the ticlCandidate trackster collection the candidate Ptrs reference (not trackstersInCand).
  • fill the previously-empty simTICLCandidate_caloParticleMass branch.
  • SuperclusteringSampleDumper: explVarRatioCut_energyBoundary_ read the wrong key.

- saveTICLCandidate_ read the wrong parameter key (saveSimTICLCandidate).
- candidate trackster index computed against the ticlCandidate trackster collection the
  candidate Ptrs reference (not trackstersInCand).
- fill the previously-empty simTICLCandidate_caloParticleMass branch.
- SuperclusteringSampleDumper: explVarRatioCut_energyBoundary_ read the wrong key.
@cmsbuild

cmsbuild commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

@cmsbuild please test

@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

  • RecoHGCal/TICL (reconstruction)

@Moanwar, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@apsallid, @denizsun, @hatakeyamak, @lecriste, @rovere, @salimcerci, @sameasy, @sobhatta this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

type bugfix

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-866b6c/54334/summary.html
COMMIT: 2460647
CMSSW: CMSSW_20_1_X_2026-06-28-0000/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51343/54334/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3414477
  • DQMHistoTests: Total failures: 49
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3414410
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

type ngt

@cmsbuild cmsbuild added the ngt label Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants