RecoHGCal/TICL: pattern-recognition correctness fixes

[felicepantaleo]

• CLUE3D: include the last barrel layer in findAndAssignTracksters; fix the +z-endcap floor in calculateDistanceToHigher (was lastLayerPerSide+1, inconsistent with density).
• FastJet: fix the per-side layer count (was lastLayer()-1, dropping endcap layers and flushing across the IP); the barrel is a single region (no mid flush).
• HGCGraph: pop the out-in DFS node before processing (popping after discarded children).
• HGCDoublet: keep the sign of minCosPointing (default -1 no longer rejects all doublets; anti-pointing doublets fail a positive threshold).

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

cms-bot internal usage

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51340/49972

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoHGCal/TICL/plugins/HGCGraph.cc modified in PR(s): Add directories for TICL-EGM code development #48319

[cmsbuild]

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

• RecoHGCal/TICL (reconstruction)

@Moanwar, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@apsallid, @denizsun, @hatakeyamak, @lecriste, @rovere, @salimcerci, @sameasy, @sobhatta this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[felicepantaleo]

type bugfix

[cmsbuild]

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19a24b/54331/summary.html
COMMIT: ad5068e
CMSSW: CMSSW_20_1_X_2026-06-27-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51340/54331/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 1102 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3414477
• DQMHistoTests: Total failures: 3891
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3410568
• DQMHistoTests: Total skipped: 18
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 195 log files, 163 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[felicepantaleo]

type ngt