Skip to content

Phase2-hgx367L Correct a bug in HGCalGeomParameters.cc to make it work correctly for the ColdBox mode of HGCal Backport from #51324#51326

Open
bsunanda wants to merge 1 commit into
cms-sw:CMSSW_17_0_Xfrom
bsunanda:Phase2-hgx367L
Open

Phase2-hgx367L Correct a bug in HGCalGeomParameters.cc to make it work correctly for the ColdBox mode of HGCal Backport from #51324#51326
bsunanda wants to merge 1 commit into
cms-sw:CMSSW_17_0_Xfrom
bsunanda:Phase2-hgx367L

Conversation

@bsunanda

Copy link
Copy Markdown
Contributor

PR description:

Correct a bug in HGCalGeomParameters.cc to make it work correctly for the ColdBox mode of HGCal Backport from #51324

PR validation:

Tested in CMSSW version 20_1_X

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport from #51324

@cmsbuild

cmsbuild commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @bsunanda for CMSSW_17_0_X.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@bsunanda

Copy link
Copy Markdown
Contributor Author

@cmsbuild Please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4853ef/54291/summary.html
COMMIT: db53a28
CMSSW: CMSSW_17_0_X_2026-06-25-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51326/54291/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4337615
  • DQMHistoTests: Total failures: 62
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4337533
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 232 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@bsunanda

Copy link
Copy Markdown
Contributor Author

+geometry

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_17_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_20_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants