Phase2-hgx367M Correct the testing code for finding neghbours of HGCal silicon cells backport of #51323

[bsunanda]

PR description:

Correct the testing code for finding neghbours of HGCal silicon cells backport of #51323

PR validation:

Tested in 20_1_X

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport from CMSsW_20_1_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51325/49949

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_17_0_X.

It involves the following packages:

• Geometry/CaloTopology (geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @fabiocos, @martinamalberti, @thomreis, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Phase2-hgx367M1 Correct the testing code for finding neghbours of HGCal silicon cells #51323

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf96fd/54290/summary.html
COMMIT: 8259817
CMSSW: CMSSW_17_0_X_2026-06-25-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51325/54290/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 54
• DQMHistoTests: Total histograms compared: 4337615
• DQMHistoTests: Total failures: 120
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4337475
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
• Checked 232 log files, 203 edm output root files, 54 DQM output files
• TriggerResults: no differences found

[bsunanda]

+geometry

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_17_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_20_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

backport of #51323