Adding GSFtracks Indices in SimTICLCandidate by Moanwar · Pull Request #51310 · cms-sw/cmssw

Moanwar · 2026-06-24T18:05:57Z

This PR adds the indices of the matched GSFtracks to the SimTICLCandidate collection. This can be used for validation studies and will also be used by MLPF to define the training targets.

cmsbuild · 2026-06-24T18:06:21Z

cms-bot internal usage

Moanwar · 2026-06-24T18:07:49Z

@cmsbuild please test

cmsbuild · 2026-06-24T18:08:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51310/49924

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HGCalReco/interface/TICLCandidate.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File DataFormats/HGCalReco/src/classes_def.xml modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/BuildFile.xml modified in PR(s): Add directories for TICL-EGM code development #48319, [DO NOT MERGE] Testing new CaloClusterSoA DataFormats #50565
- File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File RecoHGCal/TICL/python/HLTSimTracksters_cff.py modified in PR(s): Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File RecoHGCal/TICL/python/SimTracksters_cff.py modified in PR(s): Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047

cmsbuild · 2026-06-24T18:09:11Z

A new Pull Request was created by @Moanwar for master.

It involves the following packages:

DataFormats/HGCalReco (reconstruction)
RecoHGCal/TICL (reconstruction)

@Moanwar, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@apsallid, @denizsun, @felicepantaleo, @hatakeyamak, @lecriste, @missirol, @mmusich, @rovere, @salimcerci, @sameasy, @sobhatta this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2026-06-24T20:09:21Z

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e78113/54255/summary.html
COMMIT: 142bf96
CMSSW: CMSSW_20_1_X_2026-06-24-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51310/54255/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 30 lines to the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3414477
DQMHistoTests: Total failures: 39
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3414420
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 195 log files, 163 edm output root files, 45 DQM output files
TriggerResults: no differences found

Max Memory Comparisons exceeding threshold

@cms-sw/core-l2 , I found 4 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...

Error: Workflow 34434.0_TTbar_14TeV+Run4D121 step5 max memory diff -31.8 exceeds +/- 30.0 MiB
Error: Workflow 34434.911_TTbar_14TeV+Run4D121_DD4hep step5 max memory diff -31.8 exceeds +/- 30.0 MiB
Error: Workflow 34496.0_CloseByPGun_CE_E_Front_120um+Run4D121 step5 max memory diff -31.8 exceeds +/- 30.0 MiB
Error: Workflow 34500.0_CloseByPGun_CE_H_Coarse_Scint+Run4D121 step5 max memory diff -31.8 exceeds +/- 30.0 MiB

cmsbuild · 2026-06-25T16:10:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51310/49942

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HGCalReco/interface/TICLCandidate.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File DataFormats/HGCalReco/src/classes_def.xml modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/BuildFile.xml modified in PR(s): Add directories for TICL-EGM code development #48319, [DO NOT MERGE] Testing new CaloClusterSoA DataFormats #50565
- File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File RecoHGCal/TICL/python/HLTSimTracksters_cff.py modified in PR(s): Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File RecoHGCal/TICL/python/SimTracksters_cff.py modified in PR(s): Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047

cmsbuild · 2026-06-25T16:10:41Z

Pull request #51310 was updated. @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

Moanwar · 2026-06-25T16:13:13Z

@cmsbuild please test

cmsbuild · 2026-06-26T08:51:16Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

waredjeb · 2026-06-26T13:38:25Z

Error: Workflow 34434.0_TTbar_14TeV+Run4D121 step5 max memory diff -31.8 exceeds +/- 30.0 MiB
Error: Workflow 34434.911_TTbar_14TeV+Run4D121_DD4hep step5 max memory diff -31.8 exceeds +/- 30.0 MiB
Error: Workflow 34496.0_CloseByPGun_CE_E_Front_120um+Run4D121 step5 max memory diff -31.8 exceeds +/- 30.0 MiB
Error: Workflow 34500.0_CloseByPGun_CE_H_Coarse_Scint+Run4D121 step5 max memory diff -31.8 exceeds +/- 30.0 MiB

Hi @Moanwar was this reduction in memory understood? As we discussed, sounds weird that it gets reduced while we are adding information

Moanwar · 2026-06-26T15:45:14Z

Error: Workflow 34434.0_TTbar_14TeV+Run4D121 step5 max memory diff -31.8 exceeds +/- 30.0 MiB
Error: Workflow 34434.911_TTbar_14TeV+Run4D121_DD4hep step5 max memory diff -31.8 exceeds +/- 30.0 MiB
Error: Workflow 34496.0_CloseByPGun_CE_E_Front_120um+Run4D121 step5 max memory diff -31.8 exceeds +/- 30.0 MiB
Error: Workflow 34500.0_CloseByPGun_CE_H_Coarse_Scint+Run4D121 step5 max memory diff -31.8 exceeds +/- 30.0 MiB

Hi @Moanwar was this reduction in memory understood? As we discussed, sounds weird that it gets reduced while we are adding information

Hi @waredjeb, not really. The reduction in step5 is should be unrelated, and this PR doesn't affect step5 at all.
That said, I did a quick comparison using all particle types in the HGCal validation, and I get exactly the same results before and after the PR:
https://mohamed.web.cern.ch/test_TICLv5/output_51310/
So I wouldn't expect any changes. Maybe @cms-sw/core-l2 can comment on that, but from my POV this PR has no effect on step5.

Dr15Jones · 2026-06-26T16:04:47Z

We'v found that we have memory fluctuations on the order of < 30MB often. I wouldn't be surprised to see a case where that randomly fluctuated up to just over 30MB.

We'd love to know exactly what causes these. Given the code shouldn't affect harvesting and assuming the histograms filled by harvesting aren't showing any unexpected changes, I'd say it is fine to ignore the memory change.

Dr15Jones · 2026-06-26T16:09:30Z

So if I look at the memory report directly, it says a additional 513.20 MB was used by this PR compared to the base line for workflow 34634.0_TTbar_14TeV+Run4D121PU step3 (by used it means requested and released, not that the maximum memory used by the job at one time was 500MB more)

That seems like something that should be checked.

@gartung any idea why that didn't get flagged for the summary? I'm guessing since it is used and not max memory.

gartung · 2026-06-26T16:41:33Z

The test is only for max memory used. The other quantities are not checked but they can be added if needed.

cmsbuild · 2026-06-26T18:42:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51310/49965

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HGCalReco/interface/TICLCandidate.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File DataFormats/HGCalReco/src/classes_def.xml modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/BuildFile.xml modified in PR(s): Add directories for TICL-EGM code development #48319, [DO NOT MERGE] Testing new CaloClusterSoA DataFormats #50565
- File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File RecoHGCal/TICL/python/HLTSimTracksters_cff.py modified in PR(s): Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File RecoHGCal/TICL/python/SimTracksters_cff.py modified in PR(s): Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047

cmsbuild · 2026-06-26T18:43:25Z

Pull request #51310 was updated. @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

Moanwar · 2026-06-26T18:46:57Z

@cmsbuild please test

cmsbuild · 2026-06-26T20:53:43Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e78113/54320/summary.html
COMMIT: fbb4f7a
CMSSW: CMSSW_20_1_X_2026-06-26-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51310/54320/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 35 lines to the logs
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3414477
DQMHistoTests: Total failures: 37
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3414422
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 195 log files, 163 edm output root files, 45 DQM output files
TriggerResults: no differences found

Max Memory Comparisons exceeding threshold

@cms-sw/core-l2 , I found 4 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...

Error: Workflow 34434.0_TTbar_14TeV+Run4D121 step5 max memory diff -31.8 exceeds +/- 30.0 MiB
Error: Workflow 34434.911_TTbar_14TeV+Run4D121_DD4hep step5 max memory diff -31.8 exceeds +/- 30.0 MiB
Error: Workflow 34496.0_CloseByPGun_CE_E_Front_120um+Run4D121 step5 max memory diff -31.8 exceeds +/- 30.0 MiB
Error: Workflow 34500.0_CloseByPGun_CE_H_Coarse_Scint+Run4D121 step5 max memory diff -31.8 exceeds +/- 30.0 MiB

felicepantaleo · 2026-06-28T14:34:35Z

hi @Moanwar can you run the test on single electron sample, with and without pu?

adding GSFtracks Indices in SimTiclCandidate

142bf96

cmsbuild added this to the CMSSW_20_1_X milestone Jun 24, 2026

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending changes-dataformats labels Jun 24, 2026

cmsbuild added tests-started and removed tests-pending labels Jun 24, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 24, 2026

cmsbuild added tests-approved and removed tests-started labels Jun 24, 2026

improve the candidate pruning

5cf243f

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Jun 25, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 25, 2026

cmsbuild removed the tests-pending label Jun 25, 2026

cmsbuild added reconstruction-approved fully-signed and removed pending-signatures labels Jun 26, 2026

Moanwar added 2 commits June 26, 2026 20:37

reduce memory alloc

27794cd

reduce memory alloc

fbb4f7a

cmsbuild added reconstruction-pending pending-signatures tests-pending code-checks-pending and removed reconstruction-approved fully-signed tests-approved code-checks-approved labels Jun 26, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 26, 2026

cmsbuild added tests-started and removed tests-pending labels Jun 26, 2026

cmsbuild added tests-approved and removed tests-started labels Jun 26, 2026

Uh oh!

Conversation

Moanwar commented Jun 24, 2026

Uh oh!

cmsbuild commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Moanwar commented Jun 24, 2026

Uh oh!

cmsbuild commented Jun 24, 2026

Uh oh!

cmsbuild commented Jun 24, 2026

Uh oh!

cmsbuild commented Jun 24, 2026

Comparison Summary

Max Memory Comparisons exceeding threshold

Uh oh!

cmsbuild commented Jun 25, 2026

Uh oh!

cmsbuild commented Jun 25, 2026

Uh oh!

Moanwar commented Jun 25, 2026

Uh oh!

cmsbuild commented Jun 26, 2026

Uh oh!

waredjeb commented Jun 26, 2026

Uh oh!

Moanwar commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dr15Jones commented Jun 26, 2026

Uh oh!

Dr15Jones commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gartung commented Jun 26, 2026

Uh oh!

cmsbuild commented Jun 26, 2026

Uh oh!

cmsbuild commented Jun 26, 2026

Uh oh!

Moanwar commented Jun 26, 2026

Uh oh!

cmsbuild commented Jun 26, 2026

Comparison Summary

Max Memory Comparisons exceeding threshold

Uh oh!

felicepantaleo commented Jun 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cmsbuild commented Jun 24, 2026 •

edited

Loading

Moanwar commented Jun 26, 2026 •

edited

Loading

Dr15Jones commented Jun 26, 2026 •

edited

Loading