Bosonic Recoil Corrections#110
Closed
akhter-towsifa wants to merge 414 commits into
Closed
Conversation
Former-commit-id: cf26862
…mconfig modified the 'tauID' key (from 'tau'->'tauID') Former-commit-id: 98ae773
Former-commit-id: 638dcd0
Former-commit-id: 4666205
…ding_patches Former-commit-id: 36985e8
Former-commit-id: a3f3919
Former-commit-id: 23bfee4
Former-commit-id: 0a4f437
Adding patches Former-commit-id: 4c369e1
Former-commit-id: 8de8c20
Former-commit-id: 9dedded
Former-commit-id: 699cbf9
Former-commit-id: b89062f
Former-commit-id: bc8e70f
Met trg sf fix Former-commit-id: 8d901eb
- highPT ID for muons - loose deepTau WP Former-commit-id: d19d117
Former-commit-id: 8510338
removed all the parts containing: Former-commit-id: 34947fc
Former-commit-id: 04f7ce4
fixed muon sf definition Former-commit-id: 4e83344
Former-commit-id: b42b562
Former-commit-id: 66339d4
Former-commit-id: b454679
fixed muon weights bug + electron weights Former-commit-id: cb59086
Former-commit-id: 5f224c0
Former-commit-id: 44a5c51
Former-commit-id: bf39338
Former-commit-id: 8e857bd
Former-commit-id: c80ab94
Contributor
Author
|
@cms-flaf-bot please test
|
|
pipeline#14928063 started |
|
pipeline#14928063 failed |
Contributor
Author
|
@cms-flaf-bot please test
|
|
pipeline#14928348 started |
|
pipeline#14928348 passed |
Contributor
Author
|
Hi @kandrosov , this PR is ready for review |
kandrosov
requested changes
Jun 3, 2026
| return p4; | ||
| } | ||
|
|
||
| static LorentzVectorM GetLHEBosonVisP4(const RVecF& pt, |
Contributor
There was a problem hiding this comment.
What do you mean by visible p4 of LHE boson? It can't be computed based on LHE information.
| return apdg == 11 || apdg == 13 || apdg == 15; | ||
| } | ||
|
|
||
| static bool PassLHEBosonParticleSelection(const int pdgId, |
Contributor
There was a problem hiding this comment.
Why do you work with LHE Particles? I don't see where it is required as an input for corrections.
Contributor
Author
There was a problem hiding this comment.
@kandrosov you said to switch from GenPart_* to LHEPart_* objects.
Our anaTuples in bbtautau do not save GenPart_* objects at the moment. But you said LHEPart_* objects are sufficient and asked me to switch to them.
* Add a sample_type arg from the processes yaml * Add DY bbww corr * Remove dumb printout * Undo Vpt changes, update DY corrs to be handled through processes list * Only run corr if it is approved process * Formatting * Remove dead bool * Formatting and remove valid check * Fix DY bbww bug, clean header
Contributor
Author
|
@cms-flaf-bot please test
|
|
pipeline#14978977 started |
|
pipeline#14978977 failed |
* updated scare files * updated JEC tag for 2023 * python formatting * fixed JERC inputs with new files * python formatting * modified ScaRe also for legs * apply FSR later * fixed FSR application + inclusion of ScaRe application for nano pT * added possibility of choosing VXBS file or nano file * bug fix for muonScaRe + FSR computation * updated JEC tag for 2025 * apply L2L3Res only for data * fix JERC+JES application * debug 1 * debug 2 * fix for 2025 absence of mu corr * comments applied * applied comments * Fix jet.h crash and re-add GetResolutions * Move fatbjet naming to be under weight_ collection * Update to use FatJet corrections instead of Ak4 again * Add fat unc map * Add a selection arg to mu scare, avoiding crazy numbers from non-ID muons * Major rework of jet corrs * Add muscare id selection get * Python formatting * Update fatbjet naming again, make DY branches configurable from global * Fix jet corr for data, update teh mu scare for legs to use pt as selection * Remove the tag arg since it isn't consisten, re-add latest folder due to 24 and 25 not being updated * New 24 and 25 keys * Copilot comments * Rework MET to be computed on deltas, not on nano-shift * Update jet corrs to use frozen version, configured in correctionscorr * Removal of getP4VaraitionsForLegs --------- Co-authored-by: Valeria D'Amante <vdamante@cern.ch>
Contributor
Author
|
@cms-flaf-bot please test
|
|
pipeline#14984820 started |
|
pipeline#14984820 failed |
Contributor
Author
|
@cms-flaf-bot please test
|
|
pipeline#14985885 started |
|
pipeline#14985885 passed |
Contributor
Author
|
@cms-flaf-bot test please
|
|
pipeline#14989838 started |
Contributor
Author
|
@cms-flaf-bot please test
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the HLepRare recommendation, applying Bosonic Recoil Corrections
Adding version 5 of the CorrectionLib recoil files.
Related issue: https://github.com/cms-flaf/HH_bbtautau_planning/issues/81
Edit:
Konstantin said we don't need the
GenPart_*objects, we can instead do the following:LHEPart_*objects instead ofGenPart_*objects in this recoil correction.LHE_Vptforptll(orpt_ll)njet, use number of reconstructed b jets and VBF jets. use appropriate pT cuts on reco b jets and VBF jets when using njet.