Skip to content

otto/tools: cephadm upgrade script cephfs cluster with multiple fs#79

Open
JoshuaGabriel wants to merge 4 commits into
clyso:mainfrom
JoshuaGabriel:wip-cephfs-upgrade-script
Open

otto/tools: cephadm upgrade script cephfs cluster with multiple fs#79
JoshuaGabriel wants to merge 4 commits into
clyso:mainfrom
JoshuaGabriel:wip-cephfs-upgrade-script

Conversation

@JoshuaGabriel

Copy link
Copy Markdown
Collaborator

Upgrade the MDS daemons of a single CephFS filesystem without disturbing the
others, working around the cephadm limitation where
ceph orch upgrade ... --services mds.
prepares (fails / scales down) ALL filesystems instead of only the targeted one.

written by @FredNass

some features

  • non-interactive mode by default (--interactive is available)
  • setting mds_join_fs and refuse_standby_for_another_fs on some or all filesystems
  • upgrading all --all or multiple filesystems -f cephfs,cephfs2 (one after the other) in a single run
  • downgrading MDSs with --force-downgrade and appropriate warning.
  • using a specific repo other than quay.io/ceph/ceph

…ystems

Upgrade the MDS daemons of a single CephFS filesystem without disturbing the
others, working around the cephadm limitation where

Signed-off-by: Joshua Blanch <joshua.blanch@clyso.com>
@JoshuaGabriel JoshuaGabriel requested a review from trociny June 4, 2026 21:15
@JoshuaGabriel

Copy link
Copy Markdown
Collaborator Author

uploading it for now, I have looked at it briefly and it looks good, but will give a second review

@trociny trociny left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets name the file clyso-cephfs-upgrade (without .sh suffix), so it follows our convention we use for other files.

If we do not like clyso- prefix for these scripts or prefer ceph-filesystem instead of cephfs, lets change it for all scripts in tool directory.

Comment thread otto/src/clyso/ceph/otto/tools/clyso-ceph-filesystem-upgrade
Comment thread otto/src/clyso/ceph/otto/tools/clyso-ceph-filesystem-upgrade
Comment thread otto/src/clyso/ceph/otto/tools/ceph-filesystem-upgrade.sh Outdated
Added -I/-J/-R short options, fail_fs is now the default, and filesystem/method can be passed positionally
@FredNass

FredNass commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

There you go @trociny:

  • Added -I/-J/-R short options,
  • fail_fs is now the default,
  • and filesystem/method can be passed positionally.

I intentionally left --force-downgrade without a short option, to avoid a dangerous downgrade caused by confusing -F with -f (--filesystem).

I edited the script in your repo @JoshuaGabriel. Just noticed that its name is "ceph-filesystem-upgrade.sh" instead of "clyso-ceph-filesystem-upgrade.sh" in my repo. We might want to rename it to match other tools names.

Signed-off-by: Joshua Blanch <joshua.blanch@clyso.com>
@JoshuaGabriel

Copy link
Copy Markdown
Collaborator Author

should be renamed now

trociny
trociny previously approved these changes Jun 9, 2026

@trociny trociny left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Note, I have not tested it though.

Comment thread otto/src/clyso/ceph/otto/tools/clyso-ceph-filesystem-upgrade
Positional arguments now accept one or more filesystems (comma-separated and/or as separate args), just like -f, and I removed the positional method: the method is now an option only (-m/--method, default fail_fs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants