otto/tools: cephadm upgrade script cephfs cluster with multiple fs#79
otto/tools: cephadm upgrade script cephfs cluster with multiple fs#79JoshuaGabriel wants to merge 4 commits into
Conversation
…ystems Upgrade the MDS daemons of a single CephFS filesystem without disturbing the others, working around the cephadm limitation where Signed-off-by: Joshua Blanch <joshua.blanch@clyso.com>
|
uploading it for now, I have looked at it briefly and it looks good, but will give a second review |
trociny
left a comment
There was a problem hiding this comment.
Lets name the file clyso-cephfs-upgrade (without .sh suffix), so it follows our convention we use for other files.
If we do not like clyso- prefix for these scripts or prefer ceph-filesystem instead of cephfs, lets change it for all scripts in tool directory.
Added -I/-J/-R short options, fail_fs is now the default, and filesystem/method can be passed positionally
|
There you go @trociny:
I intentionally left --force-downgrade without a short option, to avoid a dangerous downgrade caused by confusing -F with -f (--filesystem). I edited the script in your repo @JoshuaGabriel. Just noticed that its name is "ceph-filesystem-upgrade.sh" instead of "clyso-ceph-filesystem-upgrade.sh" in my repo. We might want to rename it to match other tools names. |
Signed-off-by: Joshua Blanch <joshua.blanch@clyso.com>
|
should be renamed now |
trociny
left a comment
There was a problem hiding this comment.
Otherwise LGTM. Note, I have not tested it though.
Positional arguments now accept one or more filesystems (comma-separated and/or as separate args), just like -f, and I removed the positional method: the method is now an option only (-m/--method, default fail_fs
Upgrade the MDS daemons of a single CephFS filesystem without disturbing the
others, working around the cephadm limitation where
ceph orch upgrade ... --services mds.
prepares (fails / scales down) ALL filesystems instead of only the targeted one.
written by @FredNass
some features