Introduce clyso-nines#49
Open
dvanders wants to merge 31 commits into
Open
Conversation
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
…likelihood of additional failures Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
…ands Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
…wn > 0 Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
sam0044
reviewed
Jun 7, 2026
| an.add_argument('--seed', type=int, default=int(time.time()), help='random seed (default: current time)') | ||
| an.add_argument('--fudge', type=int, default=100, help='correlation "fudge" factor (default: 100)') | ||
| an.add_argument('--afr', type=float, default=0.02, help='Device AFR (default: 0.02)') | ||
| an.add_argument('--recovery-rate', type=int, default=50, help='Per-OSD data recovery rate (default: 50MBps)') |
Collaborator
There was a problem hiding this comment.
inconsistent type for --recovery-rate. For sim above, it is "float", here it is "int"
sam0044
reviewed
Jun 7, 2026
| if trials == 0: | ||
| return (0, 0) | ||
| p_hat = successes / trials | ||
| # 99.9% confidence interval using normal approximation |
Collaborator
There was a problem hiding this comment.
here the confience interval is 99.9% but in several vprint statements, it mentions 95% CI.
…cluster for analyze with fallback to default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For review