/diff/report & /diff/report-entries from GET to POST#220
Merged
Conversation
Change the HTTP method for /diff/report and /diff/report-entries endpoints from GET to POST. Otherwise it's not possible to add the needed JSON parameters to the request body. Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com> On-behalf-of: SAP t.dehler@sap.com
Update the readme because `./proto/gen_proto.sh` does no longer exist and is replaced by `make proto-gen`. Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com> On-behalf-of: SAP t.dehler@sap.com
s0nea
requested review from
aiivashchenko,
arttor,
fa-at-pulsit and
schucly
as code owners
arttor
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Hey @arttor and @aiivashchenko I tried to fix #217. Could you please take a look and let me know if there is anything wrong or missing. Thank you!
Related Issue
Link to the GitHub issue (if applicable): #217
Checklist
Signed-off-byline to certify agreement with the Developer Certificate of Origin (DCO).make testpassingNote: By submitting this PR, you agree to license your contributions under the Apache 2.0 License and follow our Code of Conduct.