feat(ui): Add credentials add/edit foundation#209
Merged
Conversation
s0nea
force-pushed
the
wip/storage-credentials-set
branch
6 times, most recently
from
9a525e6 to
1d4830e
Compare
s0nea
requested review from
aiivashchenko,
arttor,
fa-at-pulsit and
schucly
as code owners
s0nea
force-pushed
the
wip/storage-credentials-set
branch
2 times, most recently
from
edcfcc3 to
f907cd6
Compare
s0nea
force-pushed
the
wip/storage-credentials-set
branch
from
f907cd6 to
703f84d
Compare
mzymta
reviewed
May 18, 2026
| ); | ||
|
|
||
| async function initSetCredentialPage(storageName: string, alias?: string) { | ||
| state.isLoading = true; |
Collaborator
There was a problem hiding this comment.
shouldn't we also reset the hasError value to false here?
mzymta
approved these changes
May 19, 2026
Add the foundation to add and edit credentials: - Routing setup - Type definitions - API service - Store definition Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com> On-behalf-of: SAP t.dehler@sap.com
Remove async from the $reset functions because they don't contain asynchronous calls. Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com> On-behalf-of: SAP t.dehler@sap.com
s0nea
force-pushed
the
wip/storage-credentials-set
branch
from
fc06be5 to
a814c41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add the foundation to add and edit credentials:
Related Issue
Link to the GitHub issue (if applicable): #[issue number]
Checklist
Signed-off-byline to certify agreement with the Developer Certificate of Origin (DCO).make testpassingNote: By submitting this PR, you agree to license your contributions under the Apache 2.0 License and follow our Code of Conduct.