Conversation
…upports both x86_64 and arm64
Co-authored-by: Eirik A <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Owner
Author
|
hm, am i doing something wrong 🤔 |
Collaborator
I think that's expected - Mac can't run Linux binaries even if they're both ARM64. |
Owner
Author
|
I guess that makes sense. Don't know why I expected that to work. It's ultimately cloud environments where musl is most useful in |
Collaborator
|
Looks like this just passed CI - was there anything else you wanted to do here? |
Owner
Author
|
I'll run a quick sanity tomorrow against an arm environment, but locally this looks good! |
clux
added a commit
to kube-rs/controller-rs
that referenced
this pull request
Feb 27, 2024
Signed-off-by: clux <sszynrae@gmail.com>
Owner
Author
|
@eranrund all good. have a full e2e in kube-rs/version-rs#93 (i did also struggle with using cargo run with --platform in kube-rs/controller-rs#67 where it bombs out, but that's probably something else - and i am happy that i can at least use the builder pattern) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #133