Skip to content

arm draft verify#134

Closed
clux wants to merge 8 commits into
mainfrom
arm_eran
Closed

arm draft verify#134
clux wants to merge 8 commits into
mainfrom
arm_eran

Conversation

@clux

@clux clux commented Feb 26, 2024

Copy link
Copy Markdown
Owner

for #133

eranrund and others added 7 commits February 25, 2024 22:12
Co-authored-by: Eirik A <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux

clux commented Feb 26, 2024

Copy link
Copy Markdown
Owner Author

hm, am i doing something wrong 🤔

# on mac after doing just build-stable-arm and testing with the arm64 test params
./test/plaincrate/target/aarch64-unknown-linux-musl/debug/plaincrate
zsh: exec format error: ./test/plaincrate/target/aarch64-unknown-linux-musl/debug/plaincrate

Signed-off-by: clux <sszynrae@gmail.com>
@eranrund

Copy link
Copy Markdown
Collaborator

hm, am i doing something wrong 🤔

# on mac after doing just build-stable-arm and testing with the arm64 test params
./test/plaincrate/target/aarch64-unknown-linux-musl/debug/plaincrate
zsh: exec format error: ./test/plaincrate/target/aarch64-unknown-linux-musl/debug/plaincrate

I think that's expected - Mac can't run Linux binaries even if they're both ARM64.

@clux

clux commented Feb 26, 2024

Copy link
Copy Markdown
Owner Author

I guess that makes sense. Don't know why I expected that to work.

It's ultimately cloud environments where musl is most useful in arm land so not a big problem.

@eranrund

Copy link
Copy Markdown
Collaborator

Looks like this just passed CI - was there anything else you wanted to do here?

@clux

clux commented Feb 27, 2024

Copy link
Copy Markdown
Owner Author

I'll run a quick sanity tomorrow against an arm environment, but locally this looks good!

clux added a commit to kube-rs/controller-rs that referenced this pull request Feb 27, 2024
Signed-off-by: clux <sszynrae@gmail.com>
@clux

clux commented Feb 27, 2024

Copy link
Copy Markdown
Owner Author

@eranrund all good. have a full e2e in kube-rs/version-rs#93

(i did also struggle with using cargo run with --platform in kube-rs/controller-rs#67 where it bombs out, but that's probably something else - and i am happy that i can at least use the builder pattern)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants