Skip to content

Add CI guard to fail PRs when genclient.sh produces drift#8

Merged
skullydazed merged 2 commits into
mainfrom
copilot/run-genclient-test
Jun 1, 2026
Merged

Add CI guard to fail PRs when genclient.sh produces drift#8
skullydazed merged 2 commits into
mainfrom
copilot/run-genclient-test

Conversation

Copilot AI commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This PR adds a pull-request check to enforce that generated client code is current. CI now regenerates the client during PR validation and fails if that step changes tracked files or introduces untracked files.

  • What changed

    • Added a workflow step to run client generation in CI: uv run sh ./genclient.sh.
    • Added a repository-cleanliness gate immediately after generation to detect drift and fail the job when the working tree is not clean.
    • Added .venv/ to the repository root .gitignore so uv sync virtualenv artifacts do not cause false failures.
  • Why this matters

    • Prevents stale generated client artifacts from being merged.
    • Makes generation drift explicit at PR time instead of post-merge.
    • Preserves strict detection of untracked output while excluding expected local environment artifacts.
  • Workflow snippet

    - run: uv run sh ./genclient.sh
    - run: |
        if [ -n "$(git status --porcelain)" ]; then
          git status --short
          git diff
          exit 1
        fi

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

@skullydazed skullydazed merged commit 1204792 into main Jun 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants