Add parent_id to NodeChild and regenerate full Python client output#7
Merged
Conversation
Copilot created this pull request from a session on behalf of
skullydazed
May 31, 2026 15:38
View session
There was a problem hiding this comment.
Pull request overview
Adds parent_id to NodeChild responses so list items and child arrays can expose hierarchy information without extra lookups.
Changes:
- Extends
NodeChildinopenapi.yamlwith nullableparent_id. - Includes
parent_idin child/list SQL queries and serializes it when present. - Adds tests covering
parent_idin node children and node list responses.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
openapi.yaml |
Documents parent_id on NodeChild. |
db/flask.py |
Selects and serializes parent_id for list and child node rows. |
tests/test_api_nodes.py |
Verifies list and children payloads include expected parent_id values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+430
to
+432
| parent_id: | ||
| type: string | ||
| nullable: true |
Contributor
|
@copilot you forgot to regenerate the client |
Contributor
Author
Copilot
AI
changed the title
Add parent_id to NodeChild
Add May 31, 2026
parent_id to NodeChild and regenerate full Python client output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeChildresponses needed to exposeparent_idso list/children payloads carry hierarchy without extra lookups. This update also brings the committedbinctl-clientback in sync withopenapi.yamlby including the full generator output.API schema
parent_id: stringtoNodeChildinopenapi.yaml.Backend response shape
parent_id.parent_idwhen available in result rows.Generated Python client (full regen output)
NodeChildmodel now has typedparent_id.Tests
parent_idin node list items and child payloads.