Skip to content

fix(go): return nil instead of panic when AST node has invalid position #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wzekin merged 2 commits into from
Jun 1, 2026
Merged

fix(go): return nil instead of panic when AST node has invalid position #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67e02f1
fix(go): return nil instead of panic when AST node has invalid position
wzekin Jun 1, 2026
6df9391
ci: pin gopls to v0.22.0
wzekin Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/go-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
components: rust-analyzer

- name: Install gopls
run: go install golang.org/x/tools/gopls@latest
run: go install golang.org/x/tools/gopls@v0.16.2

- name: Run all tests
run: go test ./lang/... -skip '${{ env.SKIPPED_TESTS }}'
1 change: 1 addition & 0 deletions lang/golang/parser/ctx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ func GetRawContent(fset *token.FileSet, file []byte, node ast.Node, collectComme
funcName = fn.Name.Name
}
fmt.Fprintf(os.Stderr, "end < begin, file: %s, function: %s, possibly because file compilation failed\n", pos.Filename, funcName)
return nil
}
doc.Write(file[pos.Offset:endPos.Offset])
return doc.Bytes()
Expand Down
Loading