Skip to content

fix(api): rank covered calls by reward/risk, not max_profit/1000 (#13) #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bradsmithmba wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(api): rank covered calls by reward/risk, not max_profit/1000 (#13) #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/api/enhanced_strategy_recommender.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,10 @@ def _create_covered_call(self, symbol: str, current_price: float,
},
'current_price': current_price,
'days_to_expiration': self._days_to_expiration(expiration),
'profit_risk_ratio': round(max_profit / 1000, 2) # Simplified ratio for covered calls
# Reward-to-risk ratio, consistent with the spread strategies above.
# (Previously max_profit / 1000, a fabricated constant that ranked by
# raw dollar profit rather than risk-adjusted return.)
'profit_risk_ratio': round(max_profit / max_loss, 2) if max_loss > 0 else 0
}

# Helper methods
Expand Down