Skip to content

fix(cli): don't sys.exit at import when OptionsAI is unavailable (#6) #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bradsmithmba wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cli): don't sys.exit at import when OptionsAI is unavailable (#6) #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from rich.text import Text

# Import OptionsAI
_options_ai_import_error: Optional[Exception] = None
try:
# Try relative import first (when installed as package)
from ..main import OptionsAI
Expand All @@ -33,9 +34,11 @@

from main import OptionsAI
except ImportError as e:
typer.echo(f"Error importing OptionsAI: {e}", err=True)
typer.echo("Please ensure all dependencies are installed and the project is properly configured.", err=True)
sys.exit(1)
# Defer reporting to command execution. Calling sys.exit() at import
# time aborts the whole process — including pytest collection — for any
# module that merely imports this one.
OptionsAI = None
_options_ai_import_error = e

# Create Typer app
app = typer.Typer(
Expand All @@ -49,12 +52,21 @@
console = Console()

# Global OptionsAI instance
_options_ai: Optional[OptionsAI] = None
_options_ai: Optional["OptionsAI"] = None


def get_options_ai(config_path: Optional[str] = None) -> OptionsAI:
def get_options_ai(config_path: Optional[str] = None) -> "OptionsAI":
"""Get or create OptionsAI instance."""
global _options_ai
if OptionsAI is None:
console.print(
f"[red]OptionsAI is unavailable: {_options_ai_import_error}[/red]"
)
console.print(
"Please ensure all dependencies are installed and the project is "
"properly configured."
)
raise typer.Exit(1)
if _options_ai is None:
try:
_options_ai = OptionsAI(config_path=config_path)
Expand Down