fix(gitignore): anchor logs/checkpoints/models rules to repo root (#20)#24
Open
bradsmithmba wants to merge 1 commit into
Open
fix(gitignore): anchor logs/checkpoints/models rules to repo root (#20)#24bradsmithmba wants to merge 1 commit into
bradsmithmba wants to merge 1 commit into
Conversation
The `logs/`, `checkpoints/`, and `models/` rules were unanchored, so each matched a directory of that name at every level — including src/logs, src/checkpoints, and src/models. Any module added under src/models (etc.) was silently ignored by git and never committed. Anchor each to the repository root (/logs/, /checkpoints/, /models/) so they ignore only the intended root-level artifact directories, not source trees. src/models stays tracked; root model/log/checkpoint artifacts stay ignored. (The sibling `data/` rule is anchored in the PR for cloudtrainerwork#1.) Closes cloudtrainerwork#20 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignorehad three unanchored project-specific directory rules:An unanchored directory pattern matches a directory of that name at every level, so these matched
src/logs/,src/checkpoints/, andsrc/models/as well as the intended root-level artifact directories. Any module added under those source directories is silently ignored by git and never committed — the same class of bug that hid the data layer in #1.Closes #20.
Reproduction (before)
Change
Anchor each rule to the repository root:
Verification
Note
The sibling
data/rule has the identical bug and is anchored to/data/in the PR for #1 (#19). This PR intentionally leavesdata/untouched to avoid overlapping diffs; the two PRs change different lines and merge cleanly.🤖 Generated with Claude Code