fix(templates): additional RuleLabels indent fix#46
Merged
Conversation
Signed-off-by: trouaux <thomas.rouaux@sap.com>
trouaux
force-pushed
the
fix-additionalRuleLabels
branch
from
b3381a6 to
64c7bba
Compare
There was a problem hiding this comment.
Pull request overview
This PR adjusts how additionalRuleLabels are rendered in the Helm chart so that label maps are indented correctly when injected into Prometheus alert rule YAML, and bumps the chart patch version accordingly.
Changes:
- Update
additionalRuleLabelshelper to return unindented YAML so callers can control indentation consistently. - Normalize alert rule templates to include
additionalRuleLabelsvianindent 6at the call site. - Bump chart version from
1.2.10to1.2.11.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/kubernetes-operations/templates/_helpers.tpl | Removes internal indentation from additionalRuleLabels output to avoid double-indenting when included. |
| charts/kubernetes-operations/Chart.yaml | Patch version bump to reflect template fix release. |
| charts/kubernetes-operations/alerts/kubernetes-node.yaml | Moves additionalRuleLabels include to a consistent indentation pattern under labels:. |
| charts/kubernetes-operations/alerts/kubernetes-kubelet.yaml | Same indentation normalization for injected rule labels. |
| charts/kubernetes-operations/alerts/kubernetes-health.yaml | Same indentation normalization for injected rule labels. |
| charts/kubernetes-operations/alerts/kubernetes-apiserver.yaml | Same indentation normalization for injected rule labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
viennaa
approved these changes
Jun 1, 2026
viennaa
approved these changes
Jun 1, 2026
trouaux
force-pushed
the
fix-additionalRuleLabels
branch
from
0394165 to
4ab7dc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.