feat: skills の一律強制を縮小し内容を現行世代に更新（#116、v0.66.0）#131
Merged
Conversation
- tdd-workflow: 全作業一律 TDD+80% を明示要求時/カバレッジ要件時に限定（tdd-guide agent の description も整合） - verification-loop: 固定コマンド・出力打ち切り指定を例示化、grep secret 検査を専用ツール委譲に、Continuous Mode 削除 - eval-harness: 測定不能な pass@k 手書き記録と 1-5 自己採点を削除（attempts: N に改名） - prompt-patterns: ultrathink 詠唱説明を Deep Reasoning（Plan Mode / harness 制御）に置換 - frontend-patterns: React Compiler 条件付きメモ化、手書き useQuery → TanStack Query/SWR、motion 改称 - project-guidelines-example: モデル ID を claude-opus-4-8 + 確認コメントに修正 Closes #116
There was a problem hiding this comment.
Pull request overview
skills の記述を「現行世代の Claude Code 前提」に合わせて更新し、旧世代向けの過剰な一律強制・儀式・陳腐化した前提を削減する PR（#116 / v0.66.0）です。監査計画 #121（P3）で見つかった指摘に沿って、スキルの適用条件や例示コマンド、評価/検証の方法をより成果指向に整理しています。
Changes:
- tdd-workflow / tdd-guide の適用条件を「明示要求時 or カバレッジ要件のある新機能」に限定し、絶対表現・固定コマンドを緩和
- verification-loop の固定コマンド/出力打ち切りや単純 grep を撤廃し、security-review skill や diff 追加行レビュー中心に更新（Continuous Mode 削除）
- eval-harness / prompt-patterns / frontend-patterns の陳腐化前提（pass@k 手書き、ultrathink 呪文、手書き fetch hook、Framer Motion 表記など）を現行の説明へ刷新し、CHANGELOG に 0.66.0 を追加
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| skills/verification-loop/SKILL.md | 検証フェーズを成果指向にし、固定コマンド/grep 検査/Continuous Mode を整理 |
| skills/tdd-workflow/SKILL.md | TDD の適用範囲を明示要求・要件あり新機能に限定し、例示コマンドを一般化 |
| agents/tdd-guide.md | guide の description を新しい適用スコープに整合 |
| skills/eval-harness/SKILL.md | pass@k/pass^k の手書き・数値自己採点を削除し、試行回数/チェックリスト方式へ |
| skills/prompt-patterns/SKILL.md | ultrathink 機構説明を Deep Reasoning（Plan Mode/effort 制御/自然言語）へ置換 |
| skills/frontend-patterns/SKILL.md | React Compiler 前提のメモ化注記、server state ライブラリ推奨、motion への更新 |
| skills/frontend-patterns/references/state-performance.md | React Compiler 利用時のメモ化不要注記を追記 |
| skills/frontend-patterns/references/hooks-patterns.md | 手書き fetch hook を TanStack Query/SWR の最小例へ置換 |
| skills/frontend-patterns/references/forms-errors-a11y.md | Framer Motion 表記を motion（motion/react）へ更新 |
| skills/project-guidelines-example/references/code-patterns.md | 例示モデル ID を更新し、公式 docs 参照注記を追加 |
| CHANGELOG.md | v0.66.0 の変更点を追記 |
Comment on lines
+33
to
38
| ```typescript | ||
| // SWR (2.x: isLoading) | ||
| import useSWR from 'swr' | ||
|
|
||
| return { data, error, loading, refetch } | ||
| } | ||
| const { data, error, isLoading } = useSWR(`/api/users/${userId}`, fetcher) | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
LLM 性能監査計画 #121 の P3-10（#116）。8 findings 対応。
変更内容
| tail -20指定を例示に降格。grep "sk-"式 secret 検査を gitleaks/trufflehog → security-review skill → diff 追加行確認に置換。実行不能な「15 分ごと検証」Continuous Mode を削除claude-sonnet-4-5-20250514（実在しない疑いのある ID）→claude-opus-4-8+ 「公式 docs で最新確認」コメントレビュー指摘の判断
内部レビュー（code-reviewer agent）4 件のうち:
検証
Closes #116