feat: commands の低優先掃除(update-codemaps 削除・checkpoint 縮小ほか)(#115、v0.65.0)#130
Conversation
- update-codemaps 削除(静的マップは現行モデルの直接探索に劣後、コマンド数 21→20) - checkpoint: native checkpoint/rewind 委譲を明記し git マイルストーン記録に縮小 - research: マジックワード呪文削除 / update-kit: ツール選択 babysitting 削除 - test-coverage: スタック検出 + 例示に一般化 / e2e + e2e-runner: CI バージョンピン除去 - spec-kit-init: v0.10 出荷済みの現状記述に更新、5 steps 不整合修正 Closes #115
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90c90333aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - checkout | ||
| - setup-node (active LTS, cache npm) |
There was a problem hiding this comment.
Keep the CI example in valid workflow syntax
When the e2e-runner is asked to create a GitHub Actions workflow, this fenced yaml CI example is the pattern it will likely copy, but scalar entries like - checkout and - setup-node (...) are not valid workflow steps; GitHub documents step forms as jobs.<job_id>.steps[*].uses or jobs.<job_id>.steps[*].run (https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions). This can lead the agent to generate workflows that GitHub Actions rejects; keep the “verify latest versions” guidance, but preserve the uses:/with: structure or label this block as pseudocode.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR continues the #121 audit cleanup (P3-09 / #115) by removing legacy “old-model babysitting” from command/agent docs, deleting the /update-codemaps command, and tightening related documentation/tests for the new baselines.
Changes:
- Removed
/update-codemapsand updated documentation to reflect 21 → 20 commands. - Simplified
/checkpoint,/research,/test-coverage, and/spec-kit-initto remove stale/over-prescriptive guidance. - Updated
/e2e+e2e-runnerto avoid hardcoded CI version pins and adjusted unit checks accordingly.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/test-agent-definitions.sh | Updates hygiene test expectations for e2e CI baseline guidance (avoid stale pins). |
| skills/eval-harness/SKILL.md | Clarifies regression baseline wording (git SHA or checkpoint milestone). |
| README.md | Updates slash command count references (21 → 20). |
| README.en.md | Updates slash command count references (21 → 20). |
| commands/update-kit.md | Removes tool-choice babysitting note while keeping guardrails. |
| commands/update-codemaps.md | Deletes the /update-codemaps command content. |
| commands/test-coverage.md | Generalizes coverage instructions beyond npm/pnpm and fixed report paths. |
| commands/spec-kit-init.md | Fixes step count, updates v0.10+ behavior notes, and adds specify extension add git guidance. |
| commands/research.md | Removes “magic words” requirement while keeping deep-read requirement. |
| commands/e2e.md | Replaces hardcoded Actions/Node pins with “verify latest / use existing workflows” guidance. |
| commands/checkpoint.md | Shrinks checkpoint to cross-session git milestone recording + diff/test status. |
| CHANGELOG.md | Adds v0.65.0 entry documenting the above removals/changes. |
| agents/e2e-runner.md | Removes pinned Actions/Node example and reframes CI guidance. |
| agents/doc-updater.md | Generalizes doc-updater description/guardrails (codemap → generated docs/indexes). |
| test_name="agents: e2e and security guidance avoid stale pinned baselines" | ||
| if ! grep -q 'actions/checkout@v' "$PROJECT_DIR/agents/e2e-runner.md" \ | ||
| && ! grep -q 'node-version:' "$PROJECT_DIR/agents/e2e-runner.md" \ | ||
| && ! grep -q 'actions/checkout@v' "$PROJECT_DIR/commands/e2e.md" \ | ||
| && ! grep -q 'node-version:' "$PROJECT_DIR/commands/e2e.md" \ | ||
| && grep -q 'active Node LTS' "$PROJECT_DIR/agents/e2e-runner.md" \ |
| 1. Run `/verify quick` to ensure current state is clean | ||
| 2. Create a git stash or commit with checkpoint name | ||
| 3. Log checkpoint to `.claude/checkpoints.log`: | ||
| 2. Create a git commit or tag with the checkpoint name |
| - **update-codemaps を削除(#115)**: 静的コードマップの常設維持は旧モデルの探索能力不足への補償で、現行モデルは必要時の直接探索の方が常に新鮮。恣意的な「30% 変更で承認」ゲートと「Use TypeScript/Node.js」指定も同時に廃止。agents/doc-updater の codemap 言及を一般化。doc-blocker の codemaps/ allowlist は既存ユーザーの生成物保護のため残置。既存配備分は update の retired 掃除で除去(コマンド数 21 → 20) | ||
|
|
||
| ### Changed | ||
| - **checkpoint を git マイルストーン記録に縮小(#115)**: セッション内ロールバックはネイティブ checkpoint/rewind(Esc Esc / /rewind)に委譲することを明記し、本コマンドはセッション横断のマイルストーン記録専用に。記録していないデータ(過去のテスト成績・カバレッジ)との比較を要求していた verify の矛盾を解消(`git diff --stat` + 現在のテスト結果のみ報告) |
| | **doc-updater** | ドキュメント更新 | README やドキュメントの更新 | | ||
|
|
||
| ### 💬 スラッシュコマンド(21個) | ||
| ### 💬 スラッシュコマンド(20個) |
| ```yaml | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| cache: npm | ||
| - checkout | ||
| - setup-node (active LTS, cache npm) | ||
| - run: npm ci | ||
| - run: npx playwright install --with-deps |
概要
LLM 性能監査計画 #121 の P3-09(#115)。7 findings 対応。
変更内容
specify extension add git案内を追記検証
Closes #115