use sha256 instead of sha1 for releases#571
Merged
Merged
Conversation
dtasSap
force-pushed
the
sha256
branch
3 times, most recently
from
ea11d05 to
6151718
Compare
jochenehret
requested changes
Sep 26, 2025
| value: | ||
| name: no-stemcell-section | ||
| sha1: 5ee0dfe1f1b9acd14c18863061268f4156c291a4 | ||
| sha1: sha256:5ee0dfe1f1b9acd14c18863061268f4156c291a4 |
Contributor
There was a problem hiding this comment.
This is actuall too short for a SHA-256 value. Can you adapt the tests with longer test values to avoid confusion between SHA-1 and SHA-256 values?
jochenehret
requested changes
Sep 29, 2025
| value: | ||
| name: release1 | ||
| sha1: original-release1-sha1 | ||
| sha1: sha256:original-release1-sha1 |
Contributor
There was a problem hiding this comment.
These test values should be renamed to original-release1-sha256 to avoid confusion. I know, it's just cosmetics...
jochenehret
requested changes
Sep 29, 2025
| url: original-inert-release-url | ||
| version: original-inert-release-version | ||
| sha1: original-inert-release-sha1 | ||
| sha1: sha256:original-inert-release-sha1 |
Contributor
There was a problem hiding this comment.
This and the following test values should also be renamed to "-sha256"
jochenehret
approved these changes
Sep 29, 2025
davewalter
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Sha256 instead of Sha1 in releases