Skip to content

Remove defer to handle new containerregistry limiter#166

Merged
modulo11 merged 1 commit into
mainfrom
fix-download-limit
Jun 15, 2026
Merged

Remove defer to handle new containerregistry limiter#166
modulo11 merged 1 commit into
mainfrom
fix-download-limit

Conversation

@nicolasbender

@nicolasbender nicolasbender commented Jun 1, 2026

Copy link
Copy Markdown
Member

go-containerregistry introduces a limiter in the latest patch version which results in a deadlock when it needs to spawn more than 4 jobs. This enables bumping #165

@modulo11

modulo11 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Is that behavior not more like a bug in the library and should be fixed there?

If we now explicitly call Close() we should check for its error.

@nicolasbender

Copy link
Copy Markdown
Member Author

Is that behavior not more like a bug in the library and should be fixed there?

If we now explicitly call Close() we should check for its error.

We ignored the error already when we used defer, so I doubt this would change much. Regarding the library: This seems to be introduced as a safeguard and as an alternative, we could also increase the default job size. But this has the risk of failing again when the new limit is still too low

@nicolasbender

Copy link
Copy Markdown
Member Author

Is that behavior not more like a bug in the library and should be fixed there?

You are probably right, we are also not the only one with this issue but the respective PR to fix it seems to be deleted? google/go-containerregistry#2277

Co-authored-by: Johannes Dillmann <j.dillmann@sap.com>
@modulo11 modulo11 force-pushed the fix-download-limit branch from cb692bd to 6301605 Compare June 15, 2026 06:21
@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Application Runtime Platform Working Group Jun 15, 2026
@modulo11 modulo11 merged commit 0ddfe5a into main Jun 15, 2026
7 of 8 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Application Runtime Platform Working Group Jun 15, 2026
@modulo11 modulo11 deleted the fix-download-limit branch June 15, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants