[vite-plugin] Support auxiliary Workers with new config#14654
[vite-plugin] Support auxiliary Workers with new config#14654ericclemmons wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: a2c8c54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
|
|
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
Summary: enables auxiliaryWorkers[].configPath to point at a per-Worker cloudflare.config.ts when experimental.newConfig is on, routing auxiliary configs through the same @cloudflare/config conversion + watch + Build-Output path as the entry Worker.
One actionable issue (medium): relative string entrypoints in an auxiliary config are resolved against the project root instead of the auxiliary config's own directory. Everything else looks consistent with the legacy path.
|
Review posted successfully to PR #14654. I reviewed PR #14654 ([vite-plugin] Support auxiliary Workers with new config) and posted a batch review with one actionable finding: Medium — relative string entrypoints in auxiliary configs resolve against the wrong base directory. The new-config auxiliary path forces Everything else (validation guards, |
@cloudflare/autoconfig
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Adds auxiliary Worker support when
experimental.newConfigis enabled. ExistingauxiliaryWorkers[].configPathentries now point to each auxiliary Worker's TypeScript config, while legacy Wrangler config behavior remains unchanged when the experiment is disabled.The auxiliary configs use the same
@cloudflare/configconversion path as the entry Worker, participate in config dependency watching, and retain parsed config data for Build Output API emission.This is to maiintain parity with https://developers.cloudflare.com/workers/local-development/multi-workers/#single-dev-command. My preference is instead having something like this:
But that's just an incremental step to eventually having
defineProject(...)!A picture of a cute animal (not mandatory, but encouraged)